From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 10/10] C11 threads: Move implementation to sysdeps/pthread
Date: Tue, 21 Jan 2020 23:01:58 +0100 [thread overview]
Message-ID: <20200121220158.x5vtnsqtrbbagq5z@function> (raw)
In-Reply-To: <e312ce6d-817c-d76b-3ab7-dc88201a1890@linaro.org>
Adhemerval Zanella, le mar. 21 janv. 2020 09:39:31 -0300, a ecrit:
> LGTM with a small nit below.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> > --- /dev/null
> > +++ b/sysdeps/htl/thrd_current.c
> > @@ -0,0 +1,31 @@
> > +/* C11 threads current thread implementation.
> > + Copyright (C) 2018-2020 Free Software Foundation, Inc.
>
> I think this is new file.
Right, I did copy from another file, but nothing copyrightable was kept
from the original file.
> > diff --git a/sysdeps/mach/htl/thrd_yield.c b/sysdeps/mach/htl/thrd_yield.c
> > new file mode 100644
> > index 0000000000..09e218cf2e
> > --- /dev/null
> > +++ b/sysdeps/mach/htl/thrd_yield.c
> > @@ -0,0 +1,26 @@
> > +/* sched_yield -- yield the processor. Mach version.
> > + Copyright (C) 2000-2020 Free Software Foundation, Inc.
>
> I think this is new file (even though it is based on sched_yield).
Ditto, not really something copyrightable.
> > diff --git a/sysdeps/nptl/thrd_create.c b/sysdeps/nptl/thrd_create.c
> > new file mode 100644
> > index 0000000000..a9219db7bc
> > --- /dev/null
> > +++ b/sysdeps/nptl/thrd_create.c
> > @@ -0,0 +1,2 @@
> > +#define __pthread_create __pthread_create_2_1
> > +#include "../pthread/thrd_create.c"
>
> I think it better to include fall path instead of relative one.
Do you mean using #include_next ? That does not work, gcc warns that it's
discouraged in primary source file.
Samuel
next prev parent reply other threads:[~2020-01-21 22:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 18:52 [PATCH 00/10] Port C11 threads to GNU/Hurd Samuel Thibault
2020-01-14 18:52 ` [hurd,commited] htl: Add internal version of __pthread_mutex_timedlock Samuel Thibault
2020-01-14 18:52 ` [PATCH 01/10] htl: Rename _pthread_mutex_init/destroy to __pthread_mutex_init/destroy Samuel Thibault
2020-01-17 20:40 ` Adhemerval Zanella
2020-01-21 21:28 ` Samuel Thibault
2020-01-27 21:55 ` Removing internal symbols (Was: htl: Rename _pthread_mutex_init/destroy to __pthread_mutex_init/destroy) Samuel Thibault
2020-01-28 12:56 ` Adhemerval Zanella
2020-01-28 13:58 ` Removing internal symbols Florian Weimer
2020-01-14 18:52 ` [PATCH 02/10] htl: Add missing internal functions declarations Samuel Thibault
2020-01-20 17:11 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 03/10] htl: Add support for C11 threads behavior Samuel Thibault
2020-01-20 17:15 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 04/10] htl: Make __PTHREAD_ONCE_INIT more flexible Samuel Thibault
2020-01-20 18:01 ` Adhemerval Zanella
2020-01-20 18:29 ` Samuel Thibault
2020-01-14 18:52 ` [PATCH 05/10] nptl: Move nptl-specific types to separate header Samuel Thibault
2020-01-20 18:31 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 06/10] C11 threads: do not require PTHREAD_DESTRUCTOR_ITERATIONS Samuel Thibault
2020-01-20 18:40 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 07/10] C11 threads: Fix thrd_t / pthread_t compatibility assertion Samuel Thibault
2020-01-20 18:52 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 08/10] C11 threads: make thrd_join more portable Samuel Thibault
2020-01-20 18:53 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 09/10] htl: Add C11 threads types definitions Samuel Thibault
2020-01-20 19:08 ` Adhemerval Zanella
2020-01-20 20:58 ` Samuel Thibault
2020-01-21 11:35 ` Adhemerval Zanella
2020-01-14 18:52 ` [PATCH 10/10] C11 threads: Move implementation to sysdeps/pthread Samuel Thibault
2020-01-21 12:39 ` Adhemerval Zanella
2020-01-21 22:01 ` Samuel Thibault [this message]
2020-01-22 12:36 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121220158.x5vtnsqtrbbagq5z@function \
--to=samuel.thibault@ens-lyon.org \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).