From: Joseph Myers <joseph@codesourcery.com>
To: Isaku Yamahata <isaku.yamahata@gmail.com>
Cc: <libc-alpha@sourceware.org>, <isaku.yamahata@intel.com>
Subject: Re: [RFC PATCH 00/11] Library OS support
Date: Thu, 12 Sep 2019 00:10:32 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1909120003500.28563@digraph.polyomino.org.uk> (raw)
In-Reply-To: <cover.1568219399.git.isaku.yamahata@gmail.com>
On Wed, 11 Sep 2019, Isaku Yamahata wrote:
> This patch is to add Library OS(LibOS in short) to glibc.
> This is the first version of patch series to support LibOS.
I don't see anything here about host triplets being used. I'd expect
x86_64-*-libos or similar (with consequent config.sub changes being
submitted to GNU config.git) but there's nothing to indicate that, and the
patch series is lacking documentation (NEWS, install.texi / regeneration
of INSTALL, other .texi files if applicable). I'd also expect any new OS
to have appropriate additions to build-many-glibcs.py. There are a great
many complications specific to existing GNU/Linux ABIs that ought to be
irrelevant in this case (compat support for old symbol versions,
enable-kernel support for different minimum kernel versions, etc.).
Given the modification of generic files, you should verify that installed
stripped shared libraries for e.g. x86_64-linux-gnu are byte-for-byte
identical before and after the patch (or justify them not being so if they
aren't identical - I'd expect justifications of the form "this file has
line numbers in assertions that change").
There should not be any __x86_64__ conditionals in generic files; the
sysdeps structure should be used as appropriate instead.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-09-12 0:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 21:03 [RFC PATCH 00/11] Library OS support Isaku Yamahata
2019-09-11 21:03 ` [RFC PATCH 01/11] x86-64, elf: make elf_machine_lazy_rel() ignore R_X86_64_NONE Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 02/11] elf: add macro to define note section for LibOS Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 03/11] elf: " Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 04/11] elf: add stub functions for LibOS support Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 05/11] elf: add hook, __libos_map_library to dl-open.c Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 06/11] elf/rtld: introduce runtime option to disable HP_TIMING_INLINE Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 07/11] malloc: make arena size configurable on startup Isaku Yamahata
2019-09-12 1:03 ` DJ Delorie
2019-09-12 18:43 ` Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 08/11] x86-64: replace syscall instruction with SYSCALL_INST macro Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 09/11] x86-64: add nop instruction after syscall instrunction Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 10/11] x86-64: make the number of nops after syscall configurable Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 11/11] benchtests: simple benchmark to measure nop effects Isaku Yamahata
2019-09-11 21:35 ` Patrick McGehearty
2019-09-12 0:10 ` Joseph Myers [this message]
2019-09-12 1:13 ` [RFC PATCH 00/11] Library OS support Isaku Yamahata
2019-09-16 20:47 ` Joseph Myers
2019-09-17 17:46 ` Isaku Yamahata
2019-09-17 13:19 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1909120003500.28563@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=isaku.yamahata@gmail.com \
--cc=isaku.yamahata@intel.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).