unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: DJ Delorie <dj@redhat.com>
To: Isaku Yamahata <isaku.yamahata@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [RFC PATCH 07/11] malloc: make arena size configurable on startup
Date: Wed, 11 Sep 2019 21:03:59 -0400	[thread overview]
Message-ID: <xn7e6eiav4.fsf@greed.delorie.com> (raw)
In-Reply-To: <0438c6b3f81ee46abef884de161dbb4b624655db.1568219400.git.isaku.yamahata@gmail.com> (message from Isaku Yamahata on Wed, 11 Sep 2019 14:04:05 -0700)


I have no fundamental problem with tuning the heap size, but...

1. The heap size must always be a power of two; you need to enforce that
   in the tunable callback.

2. Do you have any benchmarks that show that these changes don't affect
   performance?  I don't mean differing size heaps, I mean changing a
   constant to a variable in the code.

3. I don't see the point of heap_max_specified.

  reply	other threads:[~2019-09-12  1:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 21:03 [RFC PATCH 00/11] Library OS support Isaku Yamahata
2019-09-11 21:03 ` [RFC PATCH 01/11] x86-64, elf: make elf_machine_lazy_rel() ignore R_X86_64_NONE Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 02/11] elf: add macro to define note section for LibOS Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 03/11] elf: " Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 04/11] elf: add stub functions for LibOS support Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 05/11] elf: add hook, __libos_map_library to dl-open.c Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 06/11] elf/rtld: introduce runtime option to disable HP_TIMING_INLINE Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 07/11] malloc: make arena size configurable on startup Isaku Yamahata
2019-09-12  1:03   ` DJ Delorie [this message]
2019-09-12 18:43     ` Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 08/11] x86-64: replace syscall instruction with SYSCALL_INST macro Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 09/11] x86-64: add nop instruction after syscall instrunction Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 10/11] x86-64: make the number of nops after syscall configurable Isaku Yamahata
2019-09-11 21:04 ` [RFC PATCH 11/11] benchtests: simple benchmark to measure nop effects Isaku Yamahata
2019-09-11 21:35   ` Patrick McGehearty
2019-09-12  0:10 ` [RFC PATCH 00/11] Library OS support Joseph Myers
2019-09-12  1:13   ` Isaku Yamahata
2019-09-16 20:47     ` Joseph Myers
2019-09-17 17:46       ` Isaku Yamahata
2019-09-17 13:19 ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xn7e6eiav4.fsf@greed.delorie.com \
    --to=dj@redhat.com \
    --cc=isaku.yamahata@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).