From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D44191F463 for ; Thu, 12 Sep 2019 00:10:42 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=knqgL fZiGT2qJ5vpuxV3x8PZ41obRpFmPDMIoOXjFyOH01eZ90MJacfpesTOBh/tV5IwC O2Hhzperv4pvjJxConG/+16/Bjp2nLIzBCY+HIaKALhNKOsUe04IDhh0uhmTRsc/ qBaWXYB9bq9xGZAkDAU4eoWBt503w9ZMB0iYHc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=GeOzNGkj6Fo j9LA4qatFpPVHe90=; b=ipQPIWTv0xNdN4TiLwr86haNIs6Mv68eO3s2TCLDyic PCEmAfmaP/mjcppb2f/IaJPEm60pYY3MIQJAXg4EfsInOI4PXGCm8wn5MaG8r1Vs i7ZFD9r+SpTSmdH+FpqGZim6ysGcq4E05wW7P2+VDsCPy3i+emzC7lE1FInQUx+0 = Received: (qmail 17026 invoked by alias); 12 Sep 2019 00:10:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 17011 invoked by uid 89); 12 Sep 2019 00:10:40 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: esa1.mentor.iphmx.com IronPort-SDR: czEGhCr9dePmJEQ/AZ7WZRolhVaHDzvRLczRC9izbZ1yZWS+MgP4R6OFFTicmr6A6gBbBx6bcL pOqm9q+ic5oKLkhNOmUXM/AgKzWgWFCt07coCDfNuuafUq4F85C39Q+ccFcFtR/9x8Z7Ku7BI5 hhTex5PztK45WcMf3LZTq1tzLU7TRd22PWv5xAtPyX6w687XAcmf/0IQ6XqIU9LUgnu6JalL7u j/ckVKfabKvTfOH2RBMRkcWosg4MmHrDo8MKN3op4CkOOLElMPP8wFuFmyVTh5J+V42sCOycqe b2Y= IronPort-SDR: rSJRZyD2iJQi3EncJvhGa6UKn/ehcvOduIwhely/Jv1sNPKCauMVKaAWegOpUSa7JuzakA1yAK y3xNle++bR+ah0ddzDyi+hiKWm3XMsArDq4U0PrLqz0hxJebpfZWeABuPYOiAewaU29Qqz2OMm lXM7mR2JoFne10K6/sDdFZxpD2Qe7HqywkFj3YiDKo+1A44YEiwRKxT/+kvxc15kr1Z2/7Zg93 9ovhtDBQ/PSG2VG7NghOf1LxBaRr0hcnCaNvWAkJFod14l8scepG5T2n/SIbAyyYDSz/3otsgu 16U= Date: Thu, 12 Sep 2019 00:10:32 +0000 From: Joseph Myers To: Isaku Yamahata CC: , Subject: Re: [RFC PATCH 00/11] Library OS support In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Wed, 11 Sep 2019, Isaku Yamahata wrote: > This patch is to add Library OS(LibOS in short) to glibc. > This is the first version of patch series to support LibOS. I don't see anything here about host triplets being used. I'd expect x86_64-*-libos or similar (with consequent config.sub changes being submitted to GNU config.git) but there's nothing to indicate that, and the patch series is lacking documentation (NEWS, install.texi / regeneration of INSTALL, other .texi files if applicable). I'd also expect any new OS to have appropriate additions to build-many-glibcs.py. There are a great many complications specific to existing GNU/Linux ABIs that ought to be irrelevant in this case (compat support for old symbol versions, enable-kernel support for different minimum kernel versions, etc.). Given the modification of generic files, you should verify that installed stripped shared libraries for e.g. x86_64-linux-gnu are byte-for-byte identical before and after the patch (or justify them not being so if they aren't identical - I'd expect justifications of the form "this file has line numbers in assertions that change"). There should not be any __x86_64__ conditionals in generic files; the sysdeps structure should be used as appropriate instead. -- Joseph S. Myers joseph@codesourcery.com