From: Joseph Myers <joseph@codesourcery.com>
To: Zack Weinberg <zackw@panix.com>
Cc: Carlos O'Donell <carlos@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v4] Use a proper C tokenizer to implement the obsolete typedefs test.
Date: Thu, 14 Mar 2019 18:06:45 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1903141803180.23681@digraph.polyomino.org.uk> (raw)
In-Reply-To: <CAKCAbMhuP7-GXfd6bnw12Ecu9EMEEcXhbj__NCpm3pY5qMB9sA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]
On Thu, 14 Mar 2019, Zack Weinberg wrote:
> On Thu, Mar 14, 2019 at 9:00 AM Carlos O'Donell <carlos@redhat.com> wrote:
> >
> > On 3/13/19 6:16 PM, Joseph Myers wrote:
> > > I'm seeing failures from build-many-glibcs.py for
> > > resource/check-obsolete-constructs:
> > >
> > > UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3198: ordinal not in range(128)
> > >
> > > This is with LC_ALL=C (and bits/resource.h headers containing UTF-8 µ in a
> > > comment).
>
> This did not happen in my build-many-glibcs run, possibly because I’m
> running it in a UTF-8 locale. Should build-many-glibcs perhaps be
> setting LC_ALL=C for all subprocesses?
The argument that it shouldn't is that it can be run it any valid build
environment, and glibc should build and test independent of the user's
locale - individual parts of the build should set the locale where needed
(whether to build or pass tests at all, or to achieve results that are
independent of the user's locale, e.g. when sorting data).
(So someone could reasonably run build-many-glibcs.py in different locales
and compare the results, to test whether the build is properly
locale-independent, for example.)
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2019-03-14 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 14:59 [PATCH v4] Use a proper C tokenizer to implement the obsolete typedefs test Zack Weinberg
2019-03-11 18:57 ` Carlos O'Donell
2019-03-12 0:59 ` Zack Weinberg
2019-03-12 3:47 ` Carlos O'Donell
2019-03-13 13:47 ` Zack Weinberg
2019-03-13 22:16 ` Joseph Myers
2019-03-14 13:00 ` Carlos O'Donell
2019-03-14 13:21 ` Zack Weinberg
2019-03-14 18:06 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1903141803180.23681@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).