From: Zack Weinberg <zackw@panix.com>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v4] Use a proper C tokenizer to implement the obsolete typedefs test.
Date: Wed, 13 Mar 2019 09:47:14 -0400 [thread overview]
Message-ID: <CAKCAbMgpLn-GKiP91DMyDkZ8inxe+DjzDrnUwK2=+5crcYxnGQ@mail.gmail.com> (raw)
In-Reply-To: <f1d09baf-1082-846d-ce82-6f800df50ec6@redhat.com>
On Mon, Mar 11, 2019 at 11:47 PM Carlos O'Donell <carlos@redhat.com> wrote:
> On 3/11/19 8:59 PM, Zack Weinberg wrote:
> >> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> >
> > Is it now the convention that we put Reviewed-by: lines into the final
> > commit message, or just that we say that on the mailing list?
>
> Please ad the reviewed-by lines into the final commit message.
OK, done.
> I would like to see this become the way in which we more accurately
> track reviewer participation and highlight the value of reviewers
> to everyone investing in glibc.
*nod*
> > Do you still want me to change it?
>
> No.
OK. Patch now committed.
zw
next prev parent reply other threads:[~2019-03-13 13:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 14:59 [PATCH v4] Use a proper C tokenizer to implement the obsolete typedefs test Zack Weinberg
2019-03-11 18:57 ` Carlos O'Donell
2019-03-12 0:59 ` Zack Weinberg
2019-03-12 3:47 ` Carlos O'Donell
2019-03-13 13:47 ` Zack Weinberg [this message]
2019-03-13 22:16 ` Joseph Myers
2019-03-14 13:00 ` Carlos O'Donell
2019-03-14 13:21 ` Zack Weinberg
2019-03-14 18:06 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKCAbMgpLn-GKiP91DMyDkZ8inxe+DjzDrnUwK2=+5crcYxnGQ@mail.gmail.com' \
--to=zackw@panix.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).