From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-100596-e=80x24.org@sourceware.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id 998E820248
	for <e@80x24.org>; Wed, 13 Mar 2019 13:47:30 +0000 (UTC)
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:references:in-reply-to:from:date
	:message-id:subject:to:content-type; q=dns; s=default; b=W/0TSSo
	/mdHu+yK3/BZ0qPsFYNMB1zxEwi3C/UdWxFCWtiUZBlioOMq8E7psq+oqxS9TP5k
	QQ3PhvKSa1ils7076yCYr9OQOeXwVpuMN/tqXAUr7kB4qtlPMWqOlzZrdJqysoE9
	hLPMZ8hIGPwrPR7TViRanSQ1LBU3qNnqtwsA=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:references:in-reply-to:from:date
	:message-id:subject:to:content-type; s=default; bh=gmudeHdvLijK0
	8ZgmcwA+l4CY30=; b=aQYA7V3uquR79jMnUq/BON9L2XcFCOwrVjDnnzWmfwDOv
	FJIBEQ95mmY76ebmo+o4AaMzNvlhW7CaqO1HZCQ1zJ1EKbp24I8cxfrAuO2ipAKY
	pNN+14kIw9q3VNE/dZ13cSbEem6nM+a/MWWSP83vrv8UVkJucOLR5eg9fb0jBw=
Received: (qmail 120390 invoked by alias); 13 Mar 2019 13:47:28 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-e=80x24.org@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 120379 invoked by uid 89); 13 Mar 2019 13:47:28 -0000
Authentication-Results: sourceware.org; auth=none
X-HELO: mailbackend.panix.com
MIME-Version: 1.0
References: <20190311145927.20399-1-zackw@panix.com> <36fa3d03-0dc4-bbd7-5c99-c8fe19255b8e@redhat.com>
 <CAKCAbMg-iK8MPRizK=eaWHZaZG293D6ynbnJEsZqJxiAq9Zjow@mail.gmail.com> <f1d09baf-1082-846d-ce82-6f800df50ec6@redhat.com>
In-Reply-To: <f1d09baf-1082-846d-ce82-6f800df50ec6@redhat.com>
From: Zack Weinberg <zackw@panix.com>
Date: Wed, 13 Mar 2019 09:47:14 -0400
Message-ID: <CAKCAbMgpLn-GKiP91DMyDkZ8inxe+DjzDrnUwK2=+5crcYxnGQ@mail.gmail.com>
Subject: Re: [PATCH v4] Use a proper C tokenizer to implement the obsolete
 typedefs test.
To: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"

On Mon, Mar 11, 2019 at 11:47 PM Carlos O'Donell <carlos@redhat.com> wrote:
> On 3/11/19 8:59 PM, Zack Weinberg wrote:
> >> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> >
> > Is it now the convention that we put Reviewed-by: lines into the final
> > commit message, or just that we say that on the mailing list?
>
> Please ad the reviewed-by lines into the final commit message.

OK, done.

> I would like to see this become the way in which we more accurately
> track reviewer participation and highlight the value of reviewers
> to everyone investing in glibc.

*nod*

> > Do you still want me to change it?
>
> No.

OK.  Patch now committed.

zw