From: Joseph Myers <joseph@codesourcery.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Add new Fortran vector math header file.
Date: Tue, 19 Feb 2019 17:59:07 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1902191752550.25414@digraph.polyomino.org.uk> (raw)
In-Reply-To: <cc256939-cd6c-9bce-0145-b27f7d3207ea@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
On Tue, 19 Feb 2019, Martin Liška wrote:
> Sure, fixed in attached patch.
This version is OK with the indentation in math/Makefile fixed to match
the surrounding lines, presuming x86_64 and x32 are indeed mutually
exclusive conditions for the purpose of this multilib selection.
*But* there could be potential interactions with Zack's patch
<https://sourceware.org/ml/libc-alpha/2019-02/msg00446.html> to tokenize
installed headers to check for obsolete typedefs, since that of course is
tokenizing headers as C and this is adding a Fortran header to the
installed headers. (The existing check-installed-headers tests skip
bits/* so wouldn't be affected.) So maybe we should have a way to
distinguish Fortran headers, or maybe no problems arise in practice from
tokenizing this one as C and the new Python test could change to skip such
headers (it already has checks for particular header names that shouldn't
be checked) if they cause problems in future.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-02-19 17:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 14:31 [PATCH] Add new Fortran vector math header file Martin Liška
2019-02-18 17:55 ` Joseph Myers
2019-02-19 9:18 ` Martin Liška
2019-02-19 17:59 ` Joseph Myers [this message]
2019-02-19 19:14 ` Zack Weinberg
2019-02-20 9:43 ` Martin Liška
2019-02-20 13:05 ` Zack Weinberg
2019-02-20 13:52 ` Martin Liška
2019-02-26 17:56 ` [PATCH] Fix location where math-vector-fortran.h is installed Martin Liška
2019-02-26 18:05 ` Joseph Myers
2019-02-26 18:30 ` Martin Liška
2019-02-26 21:16 ` Florian Weimer
2019-02-26 21:41 ` Zack Weinberg
2019-02-27 8:09 ` Martin Liška
2019-02-27 10:12 ` Florian Weimer
2019-02-27 10:36 ` Martin Liška
2019-02-27 11:30 ` Andreas Schwab
2019-02-27 11:53 ` Martin Liška
2019-02-27 15:00 ` Zack Weinberg
2019-02-28 13:18 ` Martin Liška
2019-02-28 13:30 ` Zack Weinberg
2019-02-28 13:32 ` Florian Weimer
2019-03-01 9:31 ` Martin Liška
2019-03-01 22:30 ` Steve Ellcey
2019-03-05 12:03 ` Martin Liška
2019-03-06 21:13 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1902191752550.25414@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).