From: Florian Weimer <fweimer@redhat.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: Zack Weinberg <zackw@panix.com>,
Joseph Myers <joseph@codesourcery.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Fix location where math-vector-fortran.h is installed.
Date: Wed, 27 Feb 2019 11:12:21 +0100 [thread overview]
Message-ID: <87o96xv8u2.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <e1bdc055-e8a8-d3a9-794e-1f722bc82f1e@suse.cz> ("Martin \=\?utf-8\?Q\?Li\=C5\=A1ka\=22's\?\= message of "Wed, 27 Feb 2019 09:09:29 +0100")
* Martin Liška:
> is_nonsysdep_header = os.access(header, os.R_OK)
> if is_nonsysdep_header:
> + # Skip Fortran header files
> + if '-*- f90 -*-' in open(header).readlines()[0]:
> + continue
Please use “with” to close the file promptly, and do not read the entire
file, like this (untested):
# Skip Fortran header files.
with open(header) as inp:
if '-*- f90 -*-' in next(inp):
continue
Thanks,
Florian
next prev parent reply other threads:[~2019-02-27 10:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 14:31 [PATCH] Add new Fortran vector math header file Martin Liška
2019-02-18 17:55 ` Joseph Myers
2019-02-19 9:18 ` Martin Liška
2019-02-19 17:59 ` Joseph Myers
2019-02-19 19:14 ` Zack Weinberg
2019-02-20 9:43 ` Martin Liška
2019-02-20 13:05 ` Zack Weinberg
2019-02-20 13:52 ` Martin Liška
2019-02-26 17:56 ` [PATCH] Fix location where math-vector-fortran.h is installed Martin Liška
2019-02-26 18:05 ` Joseph Myers
2019-02-26 18:30 ` Martin Liška
2019-02-26 21:16 ` Florian Weimer
2019-02-26 21:41 ` Zack Weinberg
2019-02-27 8:09 ` Martin Liška
2019-02-27 10:12 ` Florian Weimer [this message]
2019-02-27 10:36 ` Martin Liška
2019-02-27 11:30 ` Andreas Schwab
2019-02-27 11:53 ` Martin Liška
2019-02-27 15:00 ` Zack Weinberg
2019-02-28 13:18 ` Martin Liška
2019-02-28 13:30 ` Zack Weinberg
2019-02-28 13:32 ` Florian Weimer
2019-03-01 9:31 ` Martin Liška
2019-03-01 22:30 ` Steve Ellcey
2019-03-05 12:03 ` Martin Liška
2019-03-06 21:13 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o96xv8u2.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=mliska@suse.cz \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).