From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4912C20248 for ; Wed, 27 Feb 2019 10:12:29 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=seppNT3wenYUKTeJtWJdRU6uGSDkDlUo/5dN9KWIX15 CtHG3GMh25NQ58GgFVMi6BCyy0CpGtnvgLtK+lSVyjLfN3oJxnAjrkju3Jvo5Tvc 6CkDJjsPr9rHuUhIWCOqKnUbSBqi9peJoqSsR4aKfHv8rOduW3rhLInkDgUriUsQ = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=ICruwsQxGNnm+HGU9o8lblmhddw=; b=duR+S9DiDH7GLyrg5 /BRLHxcD9WaNB3XJJErXrA8HIfk4NglDKktPFgn1jgn2mM5tfOkHEVSGdu0C0EEb ck5iGhk3jqwO0NSbMSX7d6uYPMxH5N7+wgYXWfNTqCj7541YFKBX13Sq6DLWAJbn RG7hNuQMr/JqAon4wyeJwnmBdI= Received: (qmail 109758 invoked by alias); 27 Feb 2019 10:12:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 109739 invoked by uid 89); 27 Feb 2019 10:12:26 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Martin =?utf-8?Q?Li=C5=A1ka?= Cc: Zack Weinberg , Joseph Myers , GNU C Library Subject: Re: [PATCH] Fix location where math-vector-fortran.h is installed. References: <863ffa3b-af66-7d82-21a8-e809fd6c1b62@suse.cz> <08214004-67b7-ce24-07ec-3cd685c65038@suse.cz> <84b2b212-a70a-e18a-5929-d89d6014fb70@suse.cz> <44cd0edb-2ab3-2908-8adb-f2e06859ecfe@suse.cz> <57bb8e48-8805-91ca-9902-9c6fbc3d5360@suse.cz> <87imx62qtr.fsf@oldenburg2.str.redhat.com> Date: Wed, 27 Feb 2019 11:12:21 +0100 In-Reply-To: ("Martin \=\?utf-8\?Q\?Li\=C5\=A1ka\=22's\?\= message of "Wed, 27 Feb 2019 09:09:29 +0100") Message-ID: <87o96xv8u2.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable * Martin Li=C5=A1ka: > is_nonsysdep_header =3D os.access(header, os.R_OK) > if is_nonsysdep_header: > + # Skip Fortran header files > + if '-*- f90 -*-' in open(header).readlines()[0]: > + continue Please use =E2=80=9Cwith=E2=80=9D to close the file promptly, and do not re= ad the entire file, like this (untested): # Skip Fortran header files. with open(header) as inp: if '-*- f90 -*-' in next(inp): continue Thanks, Florian