From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 528A61F453 for ; Tue, 19 Feb 2019 17:59:18 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=qtNyo aj3ofhI8yKyw2K1EkCChpHdRb63TY84xo3NHvsik6LjQxasQqMExQ6DhVma6msi+ gUGnjBQhfGC04tMMOG7rft73gYgwN2ljAIlzQR/WhAiYbaN91fteVBZ/IMFYrFAD 4tHP3BPgzm3nTIk46qoPkfrTzvLYMkjNzB1msA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=d0krJ7R5wc9 lpdFFxdBK0bToQVM=; b=v77dpJMygT9XMOoBXGt4p9TYCFpIuL4E3J7Tcd2sXlT 9+yv0B8PrKtMFQthHbuRkMaC1B3+ZlldHTjXQBbr8hzt1JaER97H99F0burhCTqQ Esfdndyz091bRTNtX9MFCXwCi+xXNwfYS+ZMOQ6+69+SDrVbjPniTENsuu1wqOpU = Received: (qmail 102193 invoked by alias); 19 Feb 2019 17:59:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 102173 invoked by uid 89); 19 Feb 2019 17:59:15 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Tue, 19 Feb 2019 17:59:07 +0000 From: Joseph Myers To: =?ISO-8859-15?Q?Martin_Li=A8ka?= CC: Subject: Re: [PATCH] Add new Fortran vector math header file. In-Reply-To: Message-ID: References: <863ffa3b-af66-7d82-21a8-e809fd6c1b62@suse.cz> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1152306461-282464029-1550599147=:25414" ---1152306461-282464029-1550599147=:25414 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT On Tue, 19 Feb 2019, Martin Liška wrote: > Sure, fixed in attached patch. This version is OK with the indentation in math/Makefile fixed to match the surrounding lines, presuming x86_64 and x32 are indeed mutually exclusive conditions for the purpose of this multilib selection. *But* there could be potential interactions with Zack's patch to tokenize installed headers to check for obsolete typedefs, since that of course is tokenizing headers as C and this is adding a Fortran header to the installed headers. (The existing check-installed-headers tests skip bits/* so wouldn't be affected.) So maybe we should have a way to distinguish Fortran headers, or maybe no problems arise in practice from tokenizing this one as C and the new Python test could change to skip such headers (it already has checks for particular header names that shouldn't be checked) if they cause problems in future. -- Joseph S. Myers joseph@codesourcery.com ---1152306461-282464029-1550599147=:25414--