RE: [PATCH 1/5] config: Added HAVE_SVE_ASM_SUPPORT for aarch64

["naohirot@fujitsu.com" <naohirot@fujitsu.com>]

Szabolcs-san,

Thank you for your review.

> > +/* Assembler support ARMv8.2-A SVE */ #define
> HAVE_SVE_ASM_SUPPORT 0
> > +
> 
> i prefer to use HAVE_AARCH64_ prefix for aarch64 specific macros in the global
> config.h, e.g. HAVE_AARCH64_SVE_ASM

OK, I'll change it to HAVE_AARCH64_SVE_ASM.

> and i'd like to have a comment here or in configue.ac with the binutils version
> where this becomes obsolete (binutils 2.28 i think). right now the minimum
> required version is 2.25, but glibc may increase that soon to above 2.28.

I'll add the comment in config.h.in like this:

+/* Assembler support ARMv8.2-A SVE.
+   This macro becomes obsolete when glibc increased the minimum
+   required version of GNU 'binutils' to 2.28 or later. */
+#define HAVE_AARCH64_SVE_ASM 0

> > diff --git a/sysdeps/aarch64/configure.ac
> > b/sysdeps/aarch64/configure.ac index 66f755078a..389a0b4e8d 100644
> > --- a/sysdeps/aarch64/configure.ac
> > +++ b/sysdeps/aarch64/configure.ac
...
> > +if AC_TRY_COMMAND(${CC-cc} -c -march=armv8.2-a+sve conftest.s
> > +1>&AS_MESSAGE_LOG_FD); then
> > +  libc_cv_asm_sve=yes
> > +else
> > +  libc_cv_asm_sve=no
> > +fi
> > +rm -f conftest*])
> > +if test $libc_cv_asm_sve = yes; then
> > +  AC_DEFINE(HAVE_SVE_ASM_SUPPORT)
> > +fi
> 
> i would use libc_cv_aarch64_sve_asm to make it obvious that it's aarch64 specific
> setting.

OK, I'll change it to libc_cv_aarch64_sve_asm.

Thanks.
Naohiro