Re: C-kermit fails

[Zack Weinberg <zackw@panix.com>]

On Fri, Jul 24, 2020 at 3:41 PM Frank da Cruz <fdc@columbia.edu> wrote:
> Somebody else sent a simpler patch, you can see it here:
>
> http://kermitproject.org/ckglibc228.diff

This is still wrong, __FILE_defined is another implementation-use-only
symbol, and it doesn't mean that the things you're actually trying to
use are available.  (I am sorely tempted to delete it from the next
release just to underline this point.)  If you need a stopgap for now,
this is as correct as it gets:

- #ifdef _IO_file_flags            /* Linux */
+ #if __GLIBC__ >= 2           /* GNU libc >= 2.0 */

... however, we are planning to stop exposing *any* of the internals
of the FILE struct, Real Soon Now, at which point there will be
nothing you can put here that will be correct.  We will consider
adding a musl-compatible __freadahead, probably before that happens,
but the right fix, again, is to remove all the code that can call
getchar/getc(stdin), relying exclusively on read(0, &ch, 1).  Then you
wouldn't need to poke around in stdio internals on *any* platform.

> I'd encourage you to put the missing symbol (and code supporting it) back in glibc

Sorry, no, not going to put it back.

zw