From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A453A1F5AE for ; Fri, 24 Jul 2020 20:05:51 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7CA093857C64; Fri, 24 Jul 2020 20:05:49 +0000 (GMT) Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by sourceware.org (Postfix) with ESMTPS id B4F053857C41 for ; Fri, 24 Jul 2020 20:05:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B4F053857C41 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=panix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zackw@panix.com Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by mailbackend.panix.com (Postfix) with ESMTPSA id 4BD0Z23LPyz15jh for ; Fri, 24 Jul 2020 16:05:46 -0400 (EDT) Received: by mail-ej1-f42.google.com with SMTP id lx13so11154577ejb.4 for ; Fri, 24 Jul 2020 13:05:46 -0700 (PDT) X-Gm-Message-State: AOAM532meU0sCrxQZpRONVpR4JpO4A1gKxo8PiRRZUSCUVWyEcli3BqT EhCy7+AuOkOsf1O8D/gVgnYe3ZLoGYS9jveOLWY= X-Google-Smtp-Source: ABdhPJw+ftbWDQ/bRQL0/Zxfq3e8ts6C8Tm3HAVUXW3IN32tPvQKi1gVdPNgZVnojPc96fhFBEwmrYh7frBnjLZZUqU= X-Received: by 2002:a17:906:1db1:: with SMTP id u17mr10433619ejh.72.1595621145535; Fri, 24 Jul 2020 13:05:45 -0700 (PDT) MIME-Version: 1.0 References: <10CAD3CD-0170-4182-A920-EE825EBAF6B0@rmrco.com> <95d9170b-d925-5037-c841-e1fd17bb680f@cs.ucla.edu> In-Reply-To: From: Zack Weinberg Date: Fri, 24 Jul 2020 16:05:34 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: C-kermit fails To: Frank da Cruz Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Liam Stitt , Mike , GNU C Library Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Fri, Jul 24, 2020 at 3:41 PM Frank da Cruz wrote: > Somebody else sent a simpler patch, you can see it here: > > http://kermitproject.org/ckglibc228.diff This is still wrong, __FILE_defined is another implementation-use-only symbol, and it doesn't mean that the things you're actually trying to use are available. (I am sorely tempted to delete it from the next release just to underline this point.) If you need a stopgap for now, this is as correct as it gets: - #ifdef _IO_file_flags /* Linux */ + #if __GLIBC__ >= 2 /* GNU libc >= 2.0 */ ... however, we are planning to stop exposing *any* of the internals of the FILE struct, Real Soon Now, at which point there will be nothing you can put here that will be correct. We will consider adding a musl-compatible __freadahead, probably before that happens, but the right fix, again, is to remove all the code that can call getchar/getc(stdin), relying exclusively on read(0, &ch, 1). Then you wouldn't need to poke around in stdio internals on *any* platform. > I'd encourage you to put the missing symbol (and code supporting it) back in glibc Sorry, no, not going to put it back. zw