Re: [PATCH v6 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #23758]

[Zack Weinberg <zackw@panix.com>]

On Thu, Jan 17, 2019 at 1:55 PM Rafal Luzynski
<digitalfreak@lingonborough.com> wrote:
> 16.01.2019 17:17 Zack Weinberg <zackw@panix.com> wrote:
> > (It seems to me that this extension ought to be generalized to all of
> > the "macro" formats (%c, %D, %F, %r, %R, %T, %x, %X, %Ec, %Ex, %EX),
> > and to all format flags and field widths, but that would be a separate
> > patch and not appropriate for 2.29 at this point.)
>
> This may be too ambiguous and therefore impossible to implement.

Yeah, you may be right there.  It was just an idea.

> > | * As a GNU extension, the '-' and '_' flags can now be applied to '%EY'
> > |   to control how the year number is formatted; they have the same effect
> > |   that they would on %Ey.
>
> "they would" or "they would have"?

My ear says an additional "have" is not necessary, but feel free to
add it if it sounds better to you that way.

> Also, shouldn't all format specifiers be consequently quoted, like "%EY"
> and "%Ey"?  I don't mind single quotes, especially for the flags, I just
> think that %Ey (without any quotes) may not be absolutely clear.

This is NEWS, right?  In the manual it should be @code{} and no quotes
for all of them, IIRC, but yes, let's add quotes around %Ey.  It
doesn't matter to me whether they are single or double quotes.

zw