From: TAMUKI Shoichi <tamuki@linet.gr.jp>
To: Zack Weinberg <zackw@panix.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v6 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758]
Date: Thu, 17 Jan 2019 15:27:31 +0900 [thread overview]
Message-ID: <201901170627.AA04183@tamuki.linet.gr.jp> (raw)
In-Reply-To: <CAKCAbMhRPMa2=M5GFY81DypCH24C30KsCwLaypwi0rm22ubfxQ@mail.gmail.com>
Hello Zack,
Thank you for reviewing my patch's documentation and commit messages.
Almost all the things I wanted to say were expressed and I think that
is very nice.
Also, Rafal and Paul, thank you for reviewing my patch's documentation
and commit messages.
I will soon prepare a new version set of patches with these remarks
applied.
From: Zack Weinberg <zackw@panix.com>
Subject: Re: [PATCH v6 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758]
Date: Wed, 16 Jan 2019 11:17:09 -0500
> > The Japanese era name is scheduled to be changed on May 1, 2019.
> > Prior to this, change the alternative representation for year in
> > strftime to pad the number with zero to keep it constant width, so
> > that prevent the trouble we saw in the past from becoming obvious
> > again from the year after the era name changes onward.
> >
> > Since only one Japanese era name is used by each emperor's reign as
> > lately, it is rare that the year ends in one digit or lasts more than
> > three digits. In addition, the default width of month, day, hour,
> > minute, and second is 2, so adjust the default width of year the same
> > as them, and then the whole display balance is improved. Therefore,
> > it would be reasonable to set the default width padding with zero of
> > "%Ey" to 2.
>
> This commit message will not be clear to readers who are not familiar
> with Japanese era dating. I had to look it up myself. It also needs
> to make clear that %Ey is changed for all locales, not just Japanese
> locales, and this is expected to be harmless for locales that use %Ey
> for something else. (I see you mentioned this in the commit message
> for the %EY change, but it belongs here.)
>
> Based on what I learned, I suggest this instead:
>
> | In Japanese locales, strftime's alternative year format (%Ey)
> | produces the year of the current era (neng?). A new era typically
> | begins when a new emperor is enthroned. The year of the current
> | era is therefore usually a one- or two-digit number.
I'm sorry, but I did not understand the meaning of (neng?). I will
rewrite it to (Japanese Calendar) tentatively.
Regards,
TAMUKI Shoichi
next prev parent reply other threads:[~2019-01-17 6:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 4:47 [PATCH v6 0/2] strftime: Improve the width of alternative representation for year [BZ #23758] TAMUKI Shoichi
2019-01-11 4:49 ` [PATCH v6 1/2] strftime: Set the default width of "%Ey" to 2 " TAMUKI Shoichi
2019-01-16 16:17 ` Zack Weinberg
2019-01-17 6:27 ` TAMUKI Shoichi [this message]
2019-01-17 17:56 ` Rafal Luzynski
2019-01-18 2:45 ` Zack Weinberg
2019-01-18 13:59 ` TAMUKI Shoichi
2019-01-18 18:35 ` Rafal Luzynski
2019-01-18 13:56 ` TAMUKI Shoichi
2019-01-18 18:44 ` Rafal Luzynski
2019-01-19 3:51 ` TAMUKI Shoichi
2019-01-19 17:08 ` Zack Weinberg
2019-01-19 21:42 ` Rafal Luzynski
2019-01-11 4:52 ` [PATCH v6 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" " TAMUKI Shoichi
2019-01-16 16:17 ` Zack Weinberg
2019-01-17 18:54 ` Rafal Luzynski
2019-01-18 2:32 ` Zack Weinberg
-- strict thread matches above, loose matches on Subject: below --
2019-01-17 18:11 [PATCH v7 1/2] strftime: Set the default width of "%Ey" to 2 " Rafal Luzynski
2019-01-18 13:58 ` [PATCH v6 " TAMUKI Shoichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201901170627.AA04183@tamuki.linet.gr.jp \
--to=tamuki@linet.gr.jp \
--cc=libc-alpha@sourceware.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).