From: Michael Hudson-Doyle via Libc-alpha <libc-alpha@sourceware.org>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: Patrick McCarty <patrick.mccarty@intel.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] iconvconfig: Fix behaviour with --prefix [BZ #28199]
Date: Tue, 10 Aug 2021 09:44:29 +1200 [thread overview]
Message-ID: <CAJ8wqteMuFQYzD1nbq--g_MM0qMCX=XfHhnHh6-P=XxL4cXLAw@mail.gmail.com> (raw)
In-Reply-To: <20210809062740.322823-1-siddhesh@sourceware.org>
On Mon, 9 Aug 2021 at 18:28, Siddhesh Poyarekar <siddhesh@sourceware.org>
wrote:
> The consolidation of configuration parsing broke behaviour with
> --prefix, where the prefix bled into the modules cache. Accept a
> prefix which, when non-NULL, is prepended to the path when looking for
> configuration files but only the original directory is added to the
> modules cache.
>
> This has no effect on the codegen of gconv_conf since it passes NULL.
>
I've lightly tested this patch and it fixes the problem I've been
experiencing and is certainly much nicer than the patch I attached to the
bug report.
Cheers,
mwh
next prev parent reply other threads:[~2021-08-09 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 6:27 [PATCH] iconvconfig: Fix behaviour with --prefix [BZ #28199] Siddhesh Poyarekar via Libc-alpha
2021-08-09 21:44 ` Michael Hudson-Doyle via Libc-alpha [this message]
2021-08-11 6:52 ` Patrick McCarty via Libc-alpha
2021-08-11 7:16 ` Siddhesh Poyarekar via Libc-alpha
2021-08-17 2:58 ` [PING][PATCH] " Siddhesh Poyarekar
2021-08-23 2:55 ` [PING2][PATCH] " Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ8wqteMuFQYzD1nbq--g_MM0qMCX=XfHhnHh6-P=XxL4cXLAw@mail.gmail.com' \
--to=libc-alpha@sourceware.org \
--cc=michael.hudson@canonical.com \
--cc=patrick.mccarty@intel.com \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).