Re: [PATCH] iconvconfig: Fix behaviour with --prefix [BZ #28199]

[Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>]

On 8/11/21 12:22 PM, Patrick McCarty via Libc-alpha wrote:
> On 2021-08-09 at 11:57:40 +0530, Siddhesh Poyarekar wrote:
>> The consolidation of configuration parsing broke behaviour with
>> --prefix, where the prefix bled into the modules cache.  Accept a
>> prefix which, when non-NULL, is prepended to the path when looking for
>> configuration files but only the original directory is added to the
>> modules cache.
>>
>> This has no effect on the codegen of gconv_conf since it passes NULL.
>>
>> Reported-by: Patrick McCarty <patrick.mccarty@intel.com>
>> Reported-by: Michael Hudson-Doyle <michael.hudson@canonical.com>
>> Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
>> ---
>>   iconv/gconv_conf.c         |  2 +-
>>   iconv/gconv_parseconfdir.h | 21 +++++++++++++++------
>>   iconv/iconvconfig.c        | 16 ++++++++++++----
>>   3 files changed, 28 insertions(+), 11 deletions(-)
> 
> Testing the patch locally, I see that the prefix is now absent from the
> modules cache, so this change looks good on my end.

Thank you for testing Patrick and Michael.  I'll push this to master and 
the 2.34 branch once I get a code review.

Siddhesh