From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 31B1B1F8C6 for ; Mon, 9 Aug 2021 21:45:16 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 12FE3393AC0D for ; Mon, 9 Aug 2021 21:45:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 12FE3393AC0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628545515; bh=7kV65h3jNC63b9YHlmOPsBCzwdY3nj4mH0kPl4R2muc=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=aWjHiCfTK+8B5EyAm7Hnb+Cm1xMliw/JY3XotcDQvMSc1wvwn6GIse3/osEH/iJPO Pkw82oJnWHOkP7iZ42h4KgibSlAmpfT2E347r4lrIyVnPOELvnjMTnITv18lARALJk eoWgr+TnoeFdCk4XIU3qDGNGkS+gl3ObDTMQjyMw= Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by sourceware.org (Postfix) with ESMTPS id DF6AF3839424 for ; Mon, 9 Aug 2021 21:44:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF6AF3839424 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 4382B3F112 for ; Mon, 9 Aug 2021 21:44:42 +0000 (UTC) Received: by mail-pj1-f69.google.com with SMTP id o1-20020a17090aac01b029017730151351so942880pjq.3 for ; Mon, 09 Aug 2021 14:44:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QMNOS5p11ziLPJSjlkEsLIIkYkcr9vvt9O7EiYi1zVg=; b=HuXuLZNBRKFaESPvNOAUxwYFzNW6nafoDd3r6da7UYdtTv735+XCv2VZKLP5DIQA7I evjbvFVBHQiGRxgPh8mLZHr/fbaVA4BTgajEv9D+ISDUWiR8/IQOQMd+Kds+GMgMA1c3 UK/NPgeCKmF1qy65RRbe2KoOeaWFC+yMwBFs27uUZA87C04QbqHEa174bYQFFifBh7Th ZfUPZ8Zpw8PwGPMplbKaEIU+Uzaq4Dgxeo0KQQ569PYp3lVxE71z92qbWm6xFKBWLYtD 0koJTfdIIIlpywxYhsGRel30mwVa5GoHrSs3TQJFb1RmcAG0CFPM+jbcedKyaS8BZICs 8e1A== X-Gm-Message-State: AOAM532xciVsu5d/V9SLEYA/1alV4pIov7enasK0EOVSOEfd/7nAEvqD PViPgegAdRj6uaB/kWjMRx4BmIJ6HAaqBwiAGVvVLXD+c3qI/hs/WH+qG1ZBJTLkHHmkZ8DyNFE pp9X7yo9UlZRJwMeeo6X1yo7JWfILQ7zQ1DskosxLI4jcWJc/qH834g== X-Received: by 2002:aa7:868c:0:b029:3bc:e2ca:4e2f with SMTP id d12-20020aa7868c0000b02903bce2ca4e2fmr26189208pfo.73.1628545480560; Mon, 09 Aug 2021 14:44:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7ouHyvT4tm4BbztGvMR5OhGdGpQKdxXgzpY8kV9Iyf3zOilBXyJckTkpn0w+P+KA+dbEY/mdrDUwfNiMgVTk= X-Received: by 2002:aa7:868c:0:b029:3bc:e2ca:4e2f with SMTP id d12-20020aa7868c0000b02903bce2ca4e2fmr26189193pfo.73.1628545480315; Mon, 09 Aug 2021 14:44:40 -0700 (PDT) MIME-Version: 1.0 References: <20210809062740.322823-1-siddhesh@sourceware.org> In-Reply-To: <20210809062740.322823-1-siddhesh@sourceware.org> Date: Tue, 10 Aug 2021 09:44:29 +1200 Message-ID: Subject: Re: [PATCH] iconvconfig: Fix behaviour with --prefix [BZ #28199] To: Siddhesh Poyarekar Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Michael Hudson-Doyle via Libc-alpha Reply-To: Michael Hudson-Doyle Cc: Patrick McCarty , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Mon, 9 Aug 2021 at 18:28, Siddhesh Poyarekar wrote: > The consolidation of configuration parsing broke behaviour with > --prefix, where the prefix bled into the modules cache. Accept a > prefix which, when non-NULL, is prepended to the path when looking for > configuration files but only the original directory is added to the > modules cache. > > This has no effect on the codegen of gconv_conf since it passes NULL. > I've lightly tested this patch and it fixes the problem I've been experiencing and is certainly much nicer than the patch I attached to the bug report. Cheers, mwh