From: Fergus Dall via Libc-alpha <libc-alpha@sourceware.org>
To: libc-alpha@sourceware.org
Cc: fweimer@redhat.com, chromeos-toolchain@google.com,
clumptini@google.com, joseph@codesourcery.com
Subject: Re: [PATCH v4] rtld: Add --no-default-paths option
Date: Wed, 28 Jul 2021 16:12:44 +1000 [thread overview]
Message-ID: <CAAjxMxfykR936n1xmJzu-5LQhpd7vHb3_J8uezmt4tkwpp8tCQ@mail.gmail.com> (raw)
In-Reply-To: <CAAjxMxcNu72P_dmOGxvKg7UgseveYaxkURvmYWyy52k7Lo=CqA@mail.gmail.com>
Ping!
Still looking for a review
On Mon, Jul 19, 2021 at 6:34 PM Fergus Dall <sidereal@google.com> wrote:
> Ping!
>
> I haven't gotten a response for this yet.
>
> Have I adequately made the case that this feature should exist? All the
> comments on previous iterations of this patchset focused on relatively
> minor details and I'm not sure if I should take that positively or not.
>
> On Tue, Jul 6, 2021 at 8:21 PM Fergus Dall <sidereal@google.com> wrote:
>
>> Changes from previous patchset:
>> - Incorporated vapier's suggestions.
>> - Initialized the path buffers in the tests, as strcat-ing into an
>> uninitialized buffer is undefined behavior.
>> - Stop adding support_install_prefix in tst-no-default-paths-dlopen
>> when constructing the path to the system lib directory. This
>> happened to work because I tested with prefix=/, but is in general
>> unnecessary and incorrect.
>>
>>
>>
next prev parent reply other threads:[~2021-07-28 6:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 10:21 [PATCH v4] rtld: Add --no-default-paths option Fergus Dall via Libc-alpha
2021-07-06 10:21 ` [PATCH v4 1/2] " Fergus Dall via Libc-alpha
2021-07-06 10:21 ` [PATCH v4 2/2] rtld: Add tests for new " Fergus Dall via Libc-alpha
2021-07-19 8:34 ` [PATCH v4] rtld: Add " Fergus Dall via Libc-alpha
2021-07-28 6:12 ` Fergus Dall via Libc-alpha [this message]
2021-08-02 2:34 ` Fergus Dall via Libc-alpha
2021-08-02 3:44 ` Carlos O'Donell via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAjxMxfykR936n1xmJzu-5LQhpd7vHb3_J8uezmt4tkwpp8tCQ@mail.gmail.com \
--to=libc-alpha@sourceware.org \
--cc=chromeos-toolchain@google.com \
--cc=clumptini@google.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=sidereal@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).