From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3D48A1F8C6 for ; Wed, 28 Jul 2021 06:13:20 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 43B87382C407 for ; Wed, 28 Jul 2021 06:13:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43B87382C407 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627452799; bh=1adbCFz3qdO+8VosUutqDkxeesHvZoKA8iRGV5cBD4I=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OFyclAEGMy5Db3aeYQfC1X274LyO/yGMyFiq1NGEnsnAEGekhV3L7q/IJzLeOCosA Nzbs3f+/waW0ENs94sty8tyL3rB55Y7tBrBYOK17Mca3E2L52buwac/osfZHt73FLh hoxjPXXhi9laOiOxzGeX2WwtmfN7otIarXCWl7ns= Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id 893CD3857C78 for ; Wed, 28 Jul 2021 06:12:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 893CD3857C78 Received: by mail-lj1-x22b.google.com with SMTP id h11so1686038ljo.12 for ; Tue, 27 Jul 2021 23:12:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=27ewSowy1qKF0f2cCxnyFWI31zBn7hfp/VroOkHFv0w=; b=V4yPeleEY+D6N7V8xtLNf+XGoWgXy8kv4M8CqaAzfeC1mVgzdpR/gI25rCam0MVGzW 28m7W8XAeVbPfX5pis1p2Omgxw9poNa0/YZCxYDv/zmuSUi3Si+H8uQ96+Y1FDJ6R8N3 8KZIQCB8Vjiifsv8B6XRQJHzjmHhi+UTSOjEFQhL7zSLjP4zUpr75e7MzlO+hpJ7l7tV LoOu26dIJkRngaGxjppqLVC2wg2DmR2A00rRD4Cjbj7B/ZpdLVDcHeAhBR2DZEtOA0EF CO78nmLEnMk5rGO1W3jAX6A9voZnInUxNHr/oPDS2lPV3DrQ53PXCMWKw8lUh/79xJ/S Yrfg== X-Gm-Message-State: AOAM533bsPWIat6Fhn1c3vZizz72glWqyWG0CMN4jRfRhJGPmLE/Yj5e n2NbSBZ+7yQO2/5naIxLizzMVSScSJ61Gt82x45OX/pRKDw= X-Google-Smtp-Source: ABdhPJwLLvDZ3F1KUw6e/7Oq4m8LKhHtx9TQiSQ/holD2yDU5a9tqguc+8l9GrEJ20FpyYaeCUaBuKQ3WXDuDg02L64= X-Received: by 2002:a2e:2403:: with SMTP id k3mr17523381ljk.90.1627452775739; Tue, 27 Jul 2021 23:12:55 -0700 (PDT) MIME-Version: 1.0 References: <20210706102132.2170854-1-sidereal@google.com> In-Reply-To: Date: Wed, 28 Jul 2021 16:12:44 +1000 Message-ID: Subject: Re: [PATCH v4] rtld: Add --no-default-paths option To: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Fergus Dall via Libc-alpha Reply-To: Fergus Dall Cc: fweimer@redhat.com, chromeos-toolchain@google.com, clumptini@google.com, joseph@codesourcery.com Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Ping! Still looking for a review On Mon, Jul 19, 2021 at 6:34 PM Fergus Dall wrote: > Ping! > > I haven't gotten a response for this yet. > > Have I adequately made the case that this feature should exist? All the > comments on previous iterations of this patchset focused on relatively > minor details and I'm not sure if I should take that positively or not. > > On Tue, Jul 6, 2021 at 8:21 PM Fergus Dall wrote: > >> Changes from previous patchset: >> - Incorporated vapier's suggestions. >> - Initialized the path buffers in the tests, as strcat-ing into an >> uninitialized buffer is undefined behavior. >> - Stop adding support_install_prefix in tst-no-default-paths-dlopen >> when constructing the path to the system lib directory. This >> happened to work because I tested with prefix=/, but is in general >> unnecessary and incorrect. >> >> >>