From: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
To: Fergus Dall <sidereal@google.com>, libc-alpha@sourceware.org
Cc: fweimer@redhat.com, clumptini@google.com,
joseph@codesourcery.com, chromeos-toolchain@google.com
Subject: Re: [PATCH v4] rtld: Add --no-default-paths option
Date: Sun, 1 Aug 2021 23:44:17 -0400 [thread overview]
Message-ID: <0c3e99c5-d1f9-58e5-76b6-d3e1979cae15@redhat.com> (raw)
In-Reply-To: <CAAjxMxdcOOKfue9jPvyHc2m3rWm+OeW+eA8DkGFzneSCVMTNQQ@mail.gmail.com>
On 8/1/21 10:34 PM, Fergus Dall wrote:
>>>> Changes from previous patchset:
>>>> - Incorporated vapier's suggestions.
>>>> - Initialized the path buffers in the tests, as strcat-ing into an
>>>> uninitialized buffer is undefined behavior.
>>>> - Stop adding support_install_prefix in tst-no-default-paths-dlopen
>>>> when constructing the path to the system lib directory. This
>>>> happened to work because I tested with prefix=/, but is in general
>>>> unnecessary and incorrect.
I looked over the series in patchwork, particularly looking for a broader
explanation of use cases in the commit, but I didn't see it there, and
I went back over the various discussions around the patch series but didn't
see any justification there either. This doesn't constitute an objection
to the series, but just a note that the work is missing a purpose statement.
What is the purpose behind adding this behaviour?
What use cases exist?
How do users use this feature?
How do you see chromeos using the feature?
I can think of some ways to use this but I'm interested to hear your
explanation, and seeing that echoed in a man page, manual, or detailed
commit message.
--
Cheers,
Carlos.
prev parent reply other threads:[~2021-08-02 3:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 10:21 [PATCH v4] rtld: Add --no-default-paths option Fergus Dall via Libc-alpha
2021-07-06 10:21 ` [PATCH v4 1/2] " Fergus Dall via Libc-alpha
2021-07-06 10:21 ` [PATCH v4 2/2] rtld: Add tests for new " Fergus Dall via Libc-alpha
2021-07-19 8:34 ` [PATCH v4] rtld: Add " Fergus Dall via Libc-alpha
2021-07-28 6:12 ` Fergus Dall via Libc-alpha
2021-08-02 2:34 ` Fergus Dall via Libc-alpha
2021-08-02 3:44 ` Carlos O'Donell via Libc-alpha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c3e99c5-d1f9-58e5-76b6-d3e1979cae15@redhat.com \
--to=libc-alpha@sourceware.org \
--cc=carlos@redhat.com \
--cc=chromeos-toolchain@google.com \
--cc=clumptini@google.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=sidereal@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).