From: Alejandro Colomar via Libc-alpha <libc-alpha@sourceware.org>
To: "Seija K." <doremylover123@gmail.com>, libc-alpha@sourceware.org
Cc: Mike Frysinger <vapier@gentoo.org>
Subject: Re: Add restrict annotations to all functions that require it
Date: Sun, 27 Nov 2022 13:04:42 +0100 [thread overview]
Message-ID: <8ccce01f-9666-74c0-07b4-99a91e73a431@gmail.com> (raw)
In-Reply-To: <CAA42iKx9UWADYaMRGTVrnR==P8yTQzOWLV3TY65QEWLW9v-ehQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 745 bytes --]
Hi Seija,
On 11/27/22 01:56, Seija K. via Libc-alpha wrote:
> The format value has to be a string literal, every time. Otherwise, you are
> not using these functions correctly. To reinforce this fact, I put
> __restrict over every example of this I could find.
The subject and the rest of the commit message seem to say different things.
The subject says that _all_ functions have been fixed, but when I read the rest
of the commit message, it seems that only the format strings have been fixed.
Which of both is true?
From reading the patch, it seems all of them have been fixed; not only format
strings. Could you maybe reword to be a little bit more precise?
Cheers,
Alex
--
<http://www.alejandro-colomar.es/>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-27 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 0:56 Add restrict annotations to all functions that require it Seija K. via Libc-alpha
2022-11-27 11:44 ` Mike Frysinger via Libc-alpha
2022-11-27 12:00 ` Alejandro Colomar via Libc-alpha
2022-12-03 14:32 ` Alejandro Colomar via Libc-alpha
2022-12-06 23:57 ` Joseph Myers
2022-12-07 11:59 ` Alejandro Colomar via Libc-alpha
2022-12-07 19:05 ` Joseph Myers
2022-11-27 12:04 ` Alejandro Colomar via Libc-alpha [this message]
2022-11-27 12:30 ` Alejandro Colomar via Libc-alpha
2022-11-27 12:39 ` Alejandro Colomar via Libc-alpha
2022-11-28 21:17 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ccce01f-9666-74c0-07b4-99a91e73a431@gmail.com \
--to=libc-alpha@sourceware.org \
--cc=alx.manpages@gmail.com \
--cc=doremylover123@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).