unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: "bug-gnulib@gnu.org" <bug-gnulib@gnu.org>,
	Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>,
	Vaseeharan Vinayagamoorthy <Vaseeharan.Vinayagamoorthy@arm.com>
Subject: Re: [PATCH 1/5] posix: Sync regex code with gnulib
Date: Tue, 19 Jan 2021 18:16:20 +0100	[thread overview]
Message-ID: <87y2go7spn.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <c2a542ac-3dee-e6d5-9636-4720b9828719@linaro.org> (Adhemerval Zanella's message of "Tue, 19 Jan 2021 14:11:09 -0300")

* Adhemerval Zanella:

> On 19/01/2021 13:52, Florian Weimer wrote:
>> * Adhemerval Zanella via Libc-alpha:
>> 
>>> Paul, this seemed to a common pattern scatter on multiple file in gnulib.
>>> Wouldn't be better to consolidate it on cdefs.h?
>> 
>> gnulib shouldn't be using cdefs.h on glibc systems, so I think a
>> separate header would be needed.
>
> What is the problem of using cdefs.h for internal implementation? 

Isn't regex_internal.h sync'ed with gnulib?

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill


  reply	other threads:[~2021-01-19 17:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30 20:15 [PATCH 1/5] posix: Sync regex code with gnulib Adhemerval Zanella via Libc-alpha
2020-12-30 20:15 ` [PATCH 2/5] posix: Sync glob " Adhemerval Zanella via Libc-alpha
2020-12-31 21:47   ` Paul Eggert
2020-12-30 20:15 ` [PATCH 3/5] Sync intprops.h " Adhemerval Zanella via Libc-alpha
2020-12-31 21:47   ` Paul Eggert
2020-12-30 20:15 ` [PATCH 4/5] Sync flexmember.h " Adhemerval Zanella via Libc-alpha
2020-12-31 21:48   ` Paul Eggert
2020-12-30 20:15 ` [PATCH 5/5] posix: Sync fnmatch " Adhemerval Zanella via Libc-alpha
2020-12-31 21:54   ` Paul Eggert
2020-12-31 21:37 ` [PATCH 1/5] posix: Sync regex code " Paul Eggert
2021-01-19 14:16 ` Vaseeharan Vinayagamoorthy via Libc-alpha
2021-01-19 14:43   ` Adhemerval Zanella via Libc-alpha
2021-01-19 15:43     ` Bruno Haible
2021-01-20  2:55       ` Paul Eggert
2021-01-20 11:27         ` Adhemerval Zanella via Libc-alpha
2021-01-20 15:32           ` Vaseeharan Vinayagamoorthy via Libc-alpha
2021-01-20 16:05             ` Adhemerval Zanella via Libc-alpha
2021-01-20 17:46           ` Paul Eggert
2021-01-19 16:52     ` Florian Weimer via Libc-alpha
2021-01-19 17:11       ` Adhemerval Zanella via Libc-alpha
2021-01-19 17:16         ` Florian Weimer via Libc-alpha [this message]
2021-01-19 17:18           ` Adhemerval Zanella via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2go7spn.fsf@oldenburg.str.redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=Vaseeharan.Vinayagamoorthy@arm.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=bug-gnulib@gnu.org \
    --cc=fweimer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).