From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
Vaseeharan Vinayagamoorthy <Vaseeharan.Vinayagamoorthy@arm.com>
Subject: Re: [PATCH 1/5] posix: Sync regex code with gnulib
Date: Tue, 19 Jan 2021 16:43:10 +0100 [thread overview]
Message-ID: <2108975.lN1YhbmyTB@omega> (raw)
In-Reply-To: <74ac97a1-2186-1937-4595-ab7409d663d0@linaro.org>
Adhemerval Zanella wrote:
> -# if (__GNUC__ >= 7) || (__clang_major__ >= 10)
> +# if (__GNUC__ >= 7) || (defined __clang_major__ &&__clang_major__ >= 10)
I would write it as:
+# if (__GNUC__ >= 7) || (defined __clang__ && __clang_major__ >= 10)
because 'defined __clang__' is the widely known way to test for a clang
(or derivate) compiler.
Bruno
next prev parent reply other threads:[~2021-01-19 15:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 20:15 [PATCH 1/5] posix: Sync regex code with gnulib Adhemerval Zanella via Libc-alpha
2020-12-30 20:15 ` [PATCH 2/5] posix: Sync glob " Adhemerval Zanella via Libc-alpha
2020-12-31 21:47 ` Paul Eggert
2020-12-30 20:15 ` [PATCH 3/5] Sync intprops.h " Adhemerval Zanella via Libc-alpha
2020-12-31 21:47 ` Paul Eggert
2020-12-30 20:15 ` [PATCH 4/5] Sync flexmember.h " Adhemerval Zanella via Libc-alpha
2020-12-31 21:48 ` Paul Eggert
2020-12-30 20:15 ` [PATCH 5/5] posix: Sync fnmatch " Adhemerval Zanella via Libc-alpha
2020-12-31 21:54 ` Paul Eggert
2020-12-31 21:37 ` [PATCH 1/5] posix: Sync regex code " Paul Eggert
2021-01-19 14:16 ` Vaseeharan Vinayagamoorthy via Libc-alpha
2021-01-19 14:43 ` Adhemerval Zanella via Libc-alpha
2021-01-19 15:43 ` Bruno Haible [this message]
2021-01-20 2:55 ` Paul Eggert
2021-01-20 11:27 ` Adhemerval Zanella via Libc-alpha
2021-01-20 15:32 ` Vaseeharan Vinayagamoorthy via Libc-alpha
2021-01-20 16:05 ` Adhemerval Zanella via Libc-alpha
2021-01-20 17:46 ` Paul Eggert
2021-01-19 16:52 ` Florian Weimer via Libc-alpha
2021-01-19 17:11 ` Adhemerval Zanella via Libc-alpha
2021-01-19 17:16 ` Florian Weimer via Libc-alpha
2021-01-19 17:18 ` Adhemerval Zanella via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2108975.lN1YhbmyTB@omega \
--to=bruno@clisp.org \
--cc=Vaseeharan.Vinayagamoorthy@arm.com \
--cc=bug-gnulib@gnu.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).