From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0F70B1F4B4 for ; Tue, 19 Jan 2021 17:16:36 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 23945388E821; Tue, 19 Jan 2021 17:16:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 23945388E821 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611076595; bh=ycNuS0LFcfCaVW921gyEBJZId1ozfYxchkKQBknDP1Q=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=c3aQcyw6nimj3ejFWnqJ06VlELUpR/ek30uVoQB+bperOMdjTYubRFgWNkZIY/UGJ b12dZXdYDSFdmONShFZssxEiv4X+w8nA4hivm30EE9kYwlNCuGilo7UiVGJi3jhI71 UWvMCxO4li96Z5Kgy7uQGZAtZzbhzJvrJqIaLGSE= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id EB90C3857022 for ; Tue, 19 Jan 2021 17:16:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EB90C3857022 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-U3EQWoVKO1WW00piPYwX_g-1; Tue, 19 Jan 2021 12:16:28 -0500 X-MC-Unique: U3EQWoVKO1WW00piPYwX_g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 508C110074C0; Tue, 19 Jan 2021 17:16:27 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-110.ams2.redhat.com [10.36.112.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D797A60CCB; Tue, 19 Jan 2021 17:16:25 +0000 (UTC) To: Adhemerval Zanella Subject: Re: [PATCH 1/5] posix: Sync regex code with gnulib References: <20201230201507.2755086-1-adhemerval.zanella@linaro.org> <909632B5-141E-4567-8E62-3DAF91CB8E33@arm.com> <74ac97a1-2186-1937-4595-ab7409d663d0@linaro.org> <8735yw98dz.fsf@oldenburg.str.redhat.com> Date: Tue, 19 Jan 2021 18:16:20 +0100 In-Reply-To: (Adhemerval Zanella's message of "Tue, 19 Jan 2021 14:11:09 -0300") Message-ID: <87y2go7spn.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: "bug-gnulib@gnu.org" , Adhemerval Zanella via Libc-alpha , Vaseeharan Vinayagamoorthy Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella: > On 19/01/2021 13:52, Florian Weimer wrote: >> * Adhemerval Zanella via Libc-alpha: >> >>> Paul, this seemed to a common pattern scatter on multiple file in gnulib. >>> Wouldn't be better to consolidate it on cdefs.h? >> >> gnulib shouldn't be using cdefs.h on glibc systems, so I think a >> separate header would be needed. > > What is the problem of using cdefs.h for internal implementation? Isn't regex_internal.h sync'ed with gnulib? Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill