unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Fangrui Song via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Avoid nested functions in the loader (all ports) [BZ #27220]
Date: Fri, 03 Sep 2021 12:09:53 +0200	[thread overview]
Message-ID: <87tuj255se.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210823043648.2648608-1-maskray@google.com> (Fangrui Song via Libc-alpha's message of "Sun, 22 Aug 2021 21:36:48 -0700")

* Fangrui Song via Libc-alpha:

> [Alternative to https://sourceware.org/pipermail/libc-alpha/2021-August/130340.html
> This version fixes all ports and doesn't add NESTING dispatches.]
>
> dynamic-link.h is included more than once in some elf/ files (rtld.c,
> dl-conflict.c, dl-reloc.c, dl-reloc-static-pie.c) and uses GCC nested
> functions. This harms readability and the nested functions usage
> is the biggest obstacle prevents CC=clang (which doesn't support the
> feature).

This patch causes elf/tst-nodelete to fail on x86_64, powerpc64,
powerpc64le at least:

| Unique symbols test failed

I assume something is wrong with the initialization of the new global
variables.

Thanks,
Florian


  parent reply	other threads:[~2021-09-03 10:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23  4:36 [PATCH] elf: Avoid nested functions in the loader (all ports) [BZ #27220] Fangrui Song via Libc-alpha
2021-09-03  5:41 ` Fāng-ruì Sòng via Libc-alpha
2021-09-03 10:09 ` Florian Weimer via Libc-alpha [this message]
2021-09-04  3:52   ` Fangrui Song via Libc-alpha
2021-09-13 16:36     ` Fāng-ruì Sòng via Libc-alpha
2021-09-20 17:55       ` PING^2: " Fāng-ruì Sòng via Libc-alpha
2021-09-22 17:53         ` Carlos O'Donell via Libc-alpha
2021-09-22 18:09           ` Joseph Myers
2021-09-22 18:20             ` Carlos O'Donell via Libc-alpha
2021-09-22 18:40               ` Fāng-ruì Sòng via Libc-alpha
2021-09-22 19:21                 ` Joseph Myers
2021-09-22 19:44                   ` Fāng-ruì Sòng via Libc-alpha
2021-09-23 22:00                     ` Florian Weimer via Libc-alpha
2021-09-23 22:14                       ` Fāng-ruì Sòng via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuj255se.fsf@oldenburg.str.redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=fweimer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).