From: Joseph Myers <joseph@codesourcery.com>
To: "Fāng-ruì Sòng" <maskray@google.com>
Cc: Florian Weimer <fweimer@redhat.com>,
Fangrui Song via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: PING^2: [PATCH] elf: Avoid nested functions in the loader (all ports) [BZ #27220]
Date: Wed, 22 Sep 2021 19:21:32 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2109221918010.37774@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20210922184037.7anyorvbtnd5j2fm@google.com>
On Wed, 22 Sep 2021, Fāng-ruì Sòng via Libc-alpha wrote:
> I went ahead and filed https://sourceware.org/bugzilla/show_bug.cgi?id=28376
> "[meta] Build glibc with Clang"
> to collect miscellaneous small fixes.
Note also that issues regarding use of glibc installed headers should
probably be handled separately (with a separate meta-bug to depend on
them; we already have a few such bugs open, e.g. 26287). The key
difference there is that installed headers should support a wide range of
compilers, including old versions. Whereas for issues building glibc, the
conclusion in some cases may well be that a change should be made to
Clang, and only new versions with that fix supported, rather than working
around a limitation in existing Clang versions.
> About the global variables (cur_*): they are in elf/dl-reloc.c
>
> - /* String table object symbols. */
> - const char *strtab = (const void *) D_PTR (l, l_info[DT_STRTAB]);
> + cur_l = l;
> + cur_scope = scope;
> + cur_strtab = (const void *) D_PTR (cur_l, l_info[DT_STRTAB]);
>
> removing them requires more parameters to ELF_DYNAMIC_RELOCATE and
> RESOLVE_MAP.
> Is that the direction you are imagining?
Yes. Explicit parameters (whether individual parameters or in a struct)
seems cleaner than using global state to pass parameters.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2021-09-22 19:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 4:36 [PATCH] elf: Avoid nested functions in the loader (all ports) [BZ #27220] Fangrui Song via Libc-alpha
2021-09-03 5:41 ` Fāng-ruì Sòng via Libc-alpha
2021-09-03 10:09 ` Florian Weimer via Libc-alpha
2021-09-04 3:52 ` Fangrui Song via Libc-alpha
2021-09-13 16:36 ` Fāng-ruì Sòng via Libc-alpha
2021-09-20 17:55 ` PING^2: " Fāng-ruì Sòng via Libc-alpha
2021-09-22 17:53 ` Carlos O'Donell via Libc-alpha
2021-09-22 18:09 ` Joseph Myers
2021-09-22 18:20 ` Carlos O'Donell via Libc-alpha
2021-09-22 18:40 ` Fāng-ruì Sòng via Libc-alpha
2021-09-22 19:21 ` Joseph Myers [this message]
2021-09-22 19:44 ` Fāng-ruì Sòng via Libc-alpha
2021-09-23 22:00 ` Florian Weimer via Libc-alpha
2021-09-23 22:14 ` Fāng-ruì Sòng via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2109221918010.37774@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).