From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6B11B1F8C6 for ; Fri, 3 Sep 2021 10:10:38 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3174A3865483 for ; Fri, 3 Sep 2021 10:10:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3174A3865483 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1630663837; bh=hy2mGBMTfgkDpKvxXkQTty/8EAHHTmrmb1D/A/dDkBo=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=s6y1zqXOc5RMJ8ZG8dP9uHh8okRNL60HELKTAQUMrpFStQA2FJ0XK62wpIf2evaSF 2FUwanNkC+VHKmx6vkdsBKoJxk/Ed/AAEVG2jfMC0ZX/y/7iFl0h/tCCH7E1bYs+ht ozm9x/U/cJ/8aRU/PiUoOhKDvUadafpR0cRVEPFs= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1482B385840F for ; Fri, 3 Sep 2021 10:10:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1482B385840F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-lF-uJV4DOHqcEpXHEM2XVQ-1; Fri, 03 Sep 2021 06:10:02 -0400 X-MC-Unique: lF-uJV4DOHqcEpXHEM2XVQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1FF99835DE3; Fri, 3 Sep 2021 10:10:01 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB0676788D; Fri, 3 Sep 2021 10:09:54 +0000 (UTC) To: Fangrui Song via Libc-alpha Subject: Re: [PATCH] elf: Avoid nested functions in the loader (all ports) [BZ #27220] References: <20210823043648.2648608-1-maskray@google.com> Date: Fri, 03 Sep 2021 12:09:53 +0200 In-Reply-To: <20210823043648.2648608-1-maskray@google.com> (Fangrui Song via Libc-alpha's message of "Sun, 22 Aug 2021 21:36:48 -0700") Message-ID: <87tuj255se.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Fangrui Song via Libc-alpha: > [Alternative to https://sourceware.org/pipermail/libc-alpha/2021-August/130340.html > This version fixes all ports and doesn't add NESTING dispatches.] > > dynamic-link.h is included more than once in some elf/ files (rtld.c, > dl-conflict.c, dl-reloc.c, dl-reloc-static-pie.c) and uses GCC nested > functions. This harms readability and the nested functions usage > is the biggest obstacle prevents CC=clang (which doesn't support the > feature). This patch causes elf/tst-nodelete to fail on x86_64, powerpc64, powerpc64le at least: | Unique symbols test failed I assume something is wrong with the initialization of the new global variables. Thanks, Florian