From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: Carlos O'Donell <carlos@redhat.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: When can we stop writing ChangeLogs?
Date: Mon, 07 Oct 2019 14:56:32 +0200 [thread overview]
Message-ID: <87pnj8lnnj.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <87ftkdzl4v.fsf@oldenburg2.str.redhat.com> (Florian Weimer's message of "Mon, 30 Sep 2019 20:36:48 +0200")
* Florian Weimer:
> * Siddhesh Poyarekar:
>
>> On 30/09/19 11:56 am, Florian Weimer wrote:
>>> I think we need to establish a procedure for commit message review as
>>> well. I would like to be able to tell, based on the posted patch, what
>>> the commit will look like exactly. Right now, we have a lot of variance
>>> there, and there have been quite a few surprises (apart from purely
>>> accidental pushes).
>>
>> We have git commit messages documented as one of the things that a
>> contributor needs to pay attention to in the Contributor Checklist, but
>> enforcement of review has been sketchy. I can't think of a better
>> solution at the moment than a review tool that requires reviewers to
>> flag the commit message as being OK.
>
> I'm looking for something far simpler here—a script that submitters and
> reviewers can run to see what's going to be committed, and some level of
> project consensus that this is how patches should be posted.
>
> Hopefully we can get to this point while still using email for patch
> submission and review.
Upon reconsideration, I think I can make git mailinfo work for me. This
means that I do not consider the lack of a tool a blocker anymore.
Thanks,
Florian
next prev parent reply other threads:[~2019-10-07 12:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 18:55 When can we stop writing ChangeLogs? Siddhesh Poyarekar
2019-09-24 23:21 ` Adhemerval Zanella
2019-09-28 3:16 ` Carlos O'Donell
2019-09-30 14:30 ` Siddhesh Poyarekar
2019-09-30 15:56 ` Florian Weimer
2019-09-30 16:56 ` Siddhesh Poyarekar
2019-09-30 18:36 ` Florian Weimer
2019-09-30 19:27 ` Siddhesh Poyarekar
2019-09-30 19:42 ` Florian Weimer
2019-10-04 1:37 ` Gabriel F. T. Gomes
2019-10-07 2:27 ` Carlos O'Donell
2019-10-07 9:05 ` Florian Weimer
2019-10-07 9:40 ` Maciej W. Rozycki
2019-10-07 9:47 ` Florian Weimer
2019-09-30 19:31 ` Carlos O'Donell
2019-09-30 19:39 ` Siddhesh Poyarekar
2019-09-30 19:41 ` Joseph Myers
2019-09-30 19:53 ` Carlos O'Donell
2019-10-01 17:41 ` Florian Weimer
2019-10-01 20:18 ` Joseph Myers
2019-10-02 9:30 ` Florian Weimer
2019-09-30 19:52 ` Maciej W. Rozycki
2019-10-07 12:56 ` Florian Weimer [this message]
2019-10-07 13:31 ` Florian Weimer
2019-10-07 14:49 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnj8lnnj.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).