unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: <libc-alpha@sourceware.org>
Subject: Re: When can we stop writing ChangeLogs?
Date: Wed, 02 Oct 2019 11:30:15 +0200	[thread overview]
Message-ID: <87d0ffsdeg.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <87v9t8s6qm.fsf@oldenburg2.str.redhat.com> (Florian Weimer's message of "Tue, 01 Oct 2019 19:41:53 +0200")

* Florian Weimer:

> * Joseph Myers:
>
>> On Mon, 30 Sep 2019, Florian Weimer wrote:
>>
>>> I'm looking for something far simpler here—a script that submitters and
>>> reviewers can run to see what's going to be committed, and some level of
>>> project consensus that this is how patches should be posted.
>>
>> I suggest that should be "git am", as an existing known format for email 
>> patch submissions, for any case except where the patch has already been 
>> committed (and really "git am" format could probably be used there as 
>> well), the patch would be excessively large (whether because of large 
>> generated files or otherwise) or the patch contains mixed character sets 
>> which require it to be attached in compressed form to avoid it being 
>> mangled.  We can discuss details regarding e.g. scissors lines, but I 
>> think we should still aim for patch submissions that are valid for "git 
>> am" in some form - and in particular, that use "git am" markings to 
>> separate the commit message from other remarks (e.g. differences between 
>> revisions of the patch) that are not intended as part of the commit 
>> message.
>
> I'm fine with “git am” input, as long as there is a reliable way to
> extract the commit, as it would be committed if you had a matching tree.
> I do not want to go hunting for the matching in every case, particularly
> for a series of patches.
>
> Do you think that the attached script might work?

It does not work.  We need an actual patch parser because people put
random stuff before the actual patch, as suggested by the git am format.

Florian

  parent reply	other threads:[~2019-10-02  9:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20 18:55 When can we stop writing ChangeLogs? Siddhesh Poyarekar
2019-09-24 23:21 ` Adhemerval Zanella
2019-09-28  3:16   ` Carlos O'Donell
2019-09-30 14:30     ` Siddhesh Poyarekar
2019-09-30 15:56       ` Florian Weimer
2019-09-30 16:56         ` Siddhesh Poyarekar
2019-09-30 18:36           ` Florian Weimer
2019-09-30 19:27             ` Siddhesh Poyarekar
2019-09-30 19:42               ` Florian Weimer
2019-10-04  1:37                 ` Gabriel F. T. Gomes
2019-10-07  2:27                   ` Carlos O'Donell
2019-10-07  9:05                     ` Florian Weimer
2019-10-07  9:40                       ` Maciej W. Rozycki
2019-10-07  9:47                         ` Florian Weimer
2019-09-30 19:31             ` Carlos O'Donell
2019-09-30 19:39               ` Siddhesh Poyarekar
2019-09-30 19:41             ` Joseph Myers
2019-09-30 19:53               ` Carlos O'Donell
2019-10-01 17:41               ` Florian Weimer
2019-10-01 20:18                 ` Joseph Myers
2019-10-02  9:30                 ` Florian Weimer [this message]
2019-09-30 19:52             ` Maciej W. Rozycki
2019-10-07 12:56             ` Florian Weimer
2019-10-07 13:31 ` Florian Weimer
2019-10-07 14:49   ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0ffsdeg.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).