From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 54D901F4BE for ; Mon, 7 Oct 2019 12:56:43 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=m+D/vv6WoJMuSGMqtiEh4W0hbmseUHSD6fZOLR5DHE8 UVcuyRCN9w0Jdpm1KGFIKcHLhGcnM6bvtjWdZBvmviaf/vQlc6QRais0xK37ySqZ YKW5M404d+FW/mZLOgpdp+OafgVKjMwMbInksxJyvvWnDRG+JZ9XfmHxnkPTkouA = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=CyHnqYmPWQ4Rar4DTBbra+EUZms=; b=N4QgvCUf/ur6pSuoc Xm+ZsXjqyMyr1ekWvlEkBBaBiUEPVDHN7HxVGfk4kkv6EYdId0+bayef8jamRKcu lcRH+GmVzM5jBzLmonDj60VjrO3bfJL7qaI0Zm7cJFGgYXypzE4mhR5s4W9eNtC4 A5lMMPoHlIODp7g7eI5gWb7QHc= Received: (qmail 35465 invoked by alias); 7 Oct 2019 12:56:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 35457 invoked by uid 89); 7 Oct 2019 12:56:41 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Siddhesh Poyarekar Cc: Carlos O'Donell , Adhemerval Zanella , libc-alpha@sourceware.org Subject: Re: When can we stop writing ChangeLogs? References: <6ebd0e52-a18f-15fc-f4ab-cf2c3afc74e9@gotplt.org> <3bd4b069-e16b-af68-fb2f-17d2458bece5@redhat.com> <878sq522xz.fsf@oldenburg2.str.redhat.com> <52634368-ee1e-23d1-1d61-de0057e03829@gotplt.org> <87ftkdzl4v.fsf@oldenburg2.str.redhat.com> Date: Mon, 07 Oct 2019 14:56:32 +0200 In-Reply-To: <87ftkdzl4v.fsf@oldenburg2.str.redhat.com> (Florian Weimer's message of "Mon, 30 Sep 2019 20:36:48 +0200") Message-ID: <87pnj8lnnj.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable * Florian Weimer: > * Siddhesh Poyarekar: > >> On 30/09/19 11:56 am, Florian Weimer wrote: >>> I think we need to establish a procedure for commit message review as >>> well. I would like to be able to tell, based on the posted patch, what >>> the commit will look like exactly. Right now, we have a lot of variance >>> there, and there have been quite a few surprises (apart from purely >>> accidental pushes). >> >> We have git commit messages documented as one of the things that a >> contributor needs to pay attention to in the Contributor Checklist, but >> enforcement of review has been sketchy. I can't think of a better >> solution at the moment than a review tool that requires reviewers to >> flag the commit message as being OK. > > I'm looking for something far simpler here=E2=80=94a script that submitte= rs and > reviewers can run to see what's going to be committed, and some level of > project consensus that this is how patches should be posted. > > Hopefully we can get to this point while still using email for patch > submission and review. Upon reconsideration, I think I can make git mailinfo work for me. This means that I do not consider the lack of a tool a blocker anymore. Thanks, Florian