From: Florian Weimer <fw@deneb.enyo.de>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org, "Alexandra Hájková" <ahajkova@redhat.com>
Subject: Re: [PATCH] Linux: Add execveat system call wrapper
Date: Tue, 28 Apr 2020 19:15:33 +0200 [thread overview]
Message-ID: <87blnbo7ka.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2004281524440.21260@digraph.polyomino.org.uk> (Joseph Myers's message of "Tue, 28 Apr 2020 15:29:07 +0000")
* Joseph Myers:
> On Tue, 28 Apr 2020, Florian Weimer wrote:
>
>> * Joseph Myers:
>>
>> > This patch needs documentation for the new function in the glibc manual,
>> > as well as a NEWS entry for it (under "Major new features" for 2.32).
>>
>> The documentation will conflict with the manual update for the
>> existing fexecve function, so that should be reviewed first:
>>
>> <https://sourceware.org/pipermail/libc-alpha/2020-April/113176.html>
>
> That documentation is fine with me, but I'm not sure where the O_RDONLY /
> O_PATH requirement comes from. Is there some code in the Linux kernel
> (that I didn't find in a quick look at the execveat implementation) that
> imposes that requirement?
It's the deny_write_access call in do_open_execat in fs/exec.c. It
returns an ETXTBSY error if the inode has been opened anywhere for
writing, which is the case if the open flag is not O_RDONLY or O_PATH.
(Admittedly, I relied on the manual page, but I've since verified this
with a test case.)
next prev parent reply other threads:[~2020-04-28 17:15 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 12:20 [PATCH] Linux: Add execveat system call wrapper Alexandra Hájková via Libc-alpha
2020-04-28 14:17 ` Florian Weimer
2020-04-28 15:03 ` Joseph Myers
2020-04-28 15:03 ` Joseph Myers
2020-04-28 15:08 ` Florian Weimer
2020-04-28 15:29 ` Joseph Myers
2020-04-28 17:15 ` Florian Weimer [this message]
2020-04-28 17:19 ` Joseph Myers
2020-04-28 17:44 ` Adhemerval Zanella via Libc-alpha
2020-04-28 17:50 ` Florian Weimer
2020-04-28 18:31 ` Adhemerval Zanella via Libc-alpha
2020-04-30 11:15 ` Florian Weimer via Libc-alpha
2020-04-30 12:28 ` Adhemerval Zanella via Libc-alpha
2020-04-30 12:55 ` Florian Weimer via Libc-alpha
2020-04-30 19:03 ` Adhemerval Zanella via Libc-alpha
2020-04-30 12:32 ` Adhemerval Zanella via Libc-alpha
2020-11-06 21:03 ` Alexandra Hájková via Libc-alpha
2020-11-06 22:15 ` Joseph Myers
2020-11-09 18:43 ` Florian Weimer via Libc-alpha
2020-11-09 21:34 ` Yann Droneaud
2020-11-26 11:31 ` Alexandra Petlanova Hajkova via Libc-alpha
2020-11-09 20:39 ` Adhemerval Zanella via Libc-alpha
2020-12-03 13:55 ` Florian Weimer via Libc-alpha
2020-11-26 21:28 ` Alexandra Hájková via Libc-alpha
2020-11-27 14:58 ` Adhemerval Zanella via Libc-alpha
2020-11-27 17:32 ` Florian Weimer via Libc-alpha
2020-11-27 17:38 ` Adhemerval Zanella via Libc-alpha
2020-12-03 14:20 ` Alexandra Hájková via Libc-alpha
2020-12-03 14:37 ` Andreas Schwab
2020-12-08 14:44 ` Adhemerval Zanella via Libc-alpha
2020-12-08 15:18 ` Florian Weimer via Libc-alpha
2020-12-08 16:41 ` Adhemerval Zanella via Libc-alpha
2021-03-15 21:42 ` Alexandra Hájková via Libc-alpha
2021-03-15 22:12 ` Joseph Myers
2021-03-15 22:17 ` Dmitry V. Levin
2021-03-24 13:54 ` Alexandra Hájková via Libc-alpha
2021-03-26 20:36 ` Adhemerval Zanella via Libc-alpha
2021-04-02 12:13 ` Alexandra Hájková via Libc-alpha
2021-04-02 13:29 ` Adhemerval Zanella via Libc-alpha
2021-04-05 16:32 ` Alexandra Hájková via Libc-alpha
2021-04-12 10:26 ` Alexandra Hájková via Libc-alpha
2021-04-12 11:14 ` Andreas Schwab
2021-04-12 19:26 ` Alexandra Hájková via Libc-alpha
2021-04-13 19:27 ` Adhemerval Zanella via Libc-alpha
2021-04-21 18:11 ` Alexandra Hájková via Libc-alpha
2021-05-03 19:20 ` Adhemerval Zanella via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blnbo7ka.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=ahajkova@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).