Re: [PATCH] Linux: Add execveat system call wrapper

["Dmitry V. Levin" <ldv@altlinux.org>]

On Mon, Mar 15, 2021 at 10:42:05PM +0100, Alexandra Hájková via Libc-alpha wrote:
[...]
> +/* Replace the current process, executing PATH relative to DIFRD with
> + * arguments ARGV and environment ENVP.
> + * ARGV and ENVP are terminated by NULL pointers.  */
> +int
> +__execveat (int dirfd, const char *path, char *const argv[], char *const envp[],
> +            int flags)
> +{
> +  if (difrd < 0 || path == NULL || argv == NULL || envp == NULL)
> +    {
> +      __set_errno (EINVAL);
> +      return -1;
> +    }
> +
> +  __set_errno (ENOSYS);
> +  return -1;
> +}
> +stub_warning (execveat)

I'm not sure how picky we are about stubs, but "difrd < 0" looks odd
anyway: it rules out AT_FDCWD, and if "path" is absolute, then "dirfd"
shall be ignored anyway.  I suggest to drop this "difrd < 0" check.


-- 
ldv