unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "Lucas A. M. Magalhaes" <lamm@linux.ibm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3] Fix tst-pkey expectations on pkey_get [BZ #23202]
Date: Sat, 15 Feb 2020 14:12:38 +0100	[thread overview]
Message-ID: <871rqwyoxl.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20200214204442.2963-1-lamm@linux.ibm.com> (Lucas A. M. Magalhaes's message of "Fri, 14 Feb 2020 17:44:42 -0300")

* Lucas A. M. Magalhaes:

> -/* Used to check that access is revoked in signal handlers.  */
> +/* Used to check the behavior in signal handlers.  In x86 all access are
> +revoked during signal handling.  Otherwise in PowerPC the key will hold it's
> +permissions. This test accepts both approaches.  */

Please indent the comment as usual.  I think on POWER, the permissions
are inherited by the interrupted thread (there are no default
permissions for signal handlers).

Thanks,
Florian


  reply	other threads:[~2020-02-15 13:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 13:46 [PATCH] Fix tst-pkey expectations on pkey_get Lucas A. M. Magalhaes
2020-02-07 18:22 ` Florian Weimer
2020-02-11 14:03   ` Lucas A. M. Magalhaes
2020-02-11 16:08     ` Florian Weimer
2020-02-12 16:45       ` Lucas A. M. Magalhaes
2020-02-12 17:17         ` Florian Weimer
2020-02-13 18:41 ` [PATCH V2] " Lucas A. M. Magalhaes
2020-02-14 17:02   ` Florian Weimer
2020-02-14 20:44   ` [PATCH v3] Fix tst-pkey expectations on pkey_get [BZ #23202] Lucas A. M. Magalhaes
2020-02-15 13:12     ` Florian Weimer [this message]
2020-02-17 12:09       ` [PATCH v4] " Lucas A. M. Magalhaes
2020-02-17 12:50         ` Florian Weimer
2020-02-19 14:41         ` Tulio Magno Quites Machado Filho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rqwyoxl.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=lamm@linux.ibm.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).