From: Florian Weimer <fweimer@redhat.com>
To: "Lucas A. M. Magalhaes" <lamm@linux.ibm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix tst-pkey expectations on pkey_get
Date: Fri, 07 Feb 2020 19:22:16 +0100 [thread overview]
Message-ID: <87wo8y45rb.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20200207134604.29046-1-lamm@linux.ibm.com> (Lucas A. M. Magalhaes's message of "Fri, 7 Feb 2020 10:46:04 -0300")
* Lucas A. M. Magalhaes:
> Florian, Your patch including pkey_set and pkey_get looks good to me.
> Can you merge it? This one
> https://sourceware.org/ml/libc-alpha/2018-05/msg00760.html.
Thanks. Is the patch really correct for 32-bit userspace?
> With this there will be one failure on this test on powerpc machines.
> The test expects that during a signal handling the pkey_get returns
> PKEY_DISABLE_ACCESS for all keys. In my tests it returns the same
> permissions as before the signal. I couldn't find where this is done for
> x86. Is this kernel implementation?
POWER has read-disable and write-disable flags which work independently.
The kernel-defined flags cannot represent the read-disable
configuration. At the time, there was no read-disable flag allocated in
the kernel. Has this changed? (See the ”Translate” comments in my
patch.)
On x86, the hardware has write-disable and read-write-disable flags
instead, which matches the original UAPI interfaces. This is why no
translation is necessary.
Thanks,
Florian
next prev parent reply other threads:[~2020-02-07 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 13:46 [PATCH] Fix tst-pkey expectations on pkey_get Lucas A. M. Magalhaes
2020-02-07 18:22 ` Florian Weimer [this message]
2020-02-11 14:03 ` Lucas A. M. Magalhaes
2020-02-11 16:08 ` Florian Weimer
2020-02-12 16:45 ` Lucas A. M. Magalhaes
2020-02-12 17:17 ` Florian Weimer
2020-02-13 18:41 ` [PATCH V2] " Lucas A. M. Magalhaes
2020-02-14 17:02 ` Florian Weimer
2020-02-14 20:44 ` [PATCH v3] Fix tst-pkey expectations on pkey_get [BZ #23202] Lucas A. M. Magalhaes
2020-02-15 13:12 ` Florian Weimer
2020-02-17 12:09 ` [PATCH v4] " Lucas A. M. Magalhaes
2020-02-17 12:50 ` Florian Weimer
2020-02-19 14:41 ` Tulio Magno Quites Machado Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo8y45rb.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=lamm@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).