From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7C6BA1F45E for ; Sat, 15 Feb 2020 13:12:49 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=cyMkZ2ESO53hg8R9eyWE1jdxoWPsmMu7xBZOL+j6rwy YEkTdQcYuxq9N5gKHYFKIEAAuGnHjloBohAcqRfy323TrBCAH5IPHvhYsFn3viTO SUdDglvzQZObnarqUxv6PHAvwlcI+odVsESgKWJpwR/u57Q7MgBkCPibYGZfnA8Q = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=Q0Wf7ANK2L5HWuk+9B+6UI3FBlg=; b=Rjm7PR9pfRXPlf5GB 8OpcrYstfObipWxaPO+b4M9Nb+ZYtBeppbrpxAiXWWQZ5lQ63EawWq9vEotYjVPv xKNLYDhWD0TXD0CwfqP3p0Mxenua2Vld+6EIjVPtDPZ6SdYrYRHfoiPHvZEnBat1 8/9QZGqdsOaoaMgjWGiIpQoNcM= Received: (qmail 74397 invoked by alias); 15 Feb 2020 13:12:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 74389 invoked by uid 89); 15 Feb 2020 13:12:46 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581772364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NK6+GUgZk8hqe4Br6EnH6u2Rmjp4jmLabqLHEKQHHK8=; b=UzevMJBMcLhKscze/oClIoe+sIocuzW2fIGXOU68KHrhhGED0fauu2WTanuNiwS2jTLwAO +081IN2htWhJi0p2PvZH76OGJ99h6xZj38aMXeUQ7F0jGW8nqNBB8jqdPIUumD65FI7SLj FOd3asKRJ5QG2SDhBRAXrWVWOyopw6w= From: Florian Weimer To: "Lucas A. M. Magalhaes" Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3] Fix tst-pkey expectations on pkey_get [BZ #23202] References: <20200213184157.16778-1-lamm@linux.ibm.com> <20200214204442.2963-1-lamm@linux.ibm.com> Date: Sat, 15 Feb 2020 14:12:38 +0100 In-Reply-To: <20200214204442.2963-1-lamm@linux.ibm.com> (Lucas A. M. Magalhaes's message of "Fri, 14 Feb 2020 17:44:42 -0300") Message-ID: <871rqwyoxl.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * Lucas A. M. Magalhaes: > -/* Used to check that access is revoked in signal handlers. */ > +/* Used to check the behavior in signal handlers. In x86 all access are > +revoked during signal handling. Otherwise in PowerPC the key will hold = it's > +permissions. This test accepts both approaches. */ Please indent the comment as usual. I think on POWER, the permissions are inherited by the interrupted thread (there are no default permissions for signal handlers). Thanks, Florian