From: Carlos O'Donell <carlos@redhat.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>,
GLIBC Devel <libc-alpha@sourceware.org>
Cc: Rafal Luzynski <digitalfreak@lingonborough.com>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: 2.29 freeze update: Last fortnight
Date: Mon, 21 Jan 2019 23:21:45 -0500 [thread overview]
Message-ID: <44bd049f-b6c9-45f8-14fc-f56f54f3e1d6@redhat.com> (raw)
In-Reply-To: <21e0277e-9b46-75b8-12d8-47464717e2f0@gotplt.org>
On 1/21/19 10:28 PM, Siddhesh Poyarekar wrote:
> On 16/01/19 9:17 AM, Siddhesh Poyarekar wrote:
>> On 16/01/19 1:47 AM, Carlos O'Donell wrote:
>>> I'm working at trying to fix the rwlock bug. I'd like to see the bug
>>> fix included in the release. I think I need the rest of the week to
>>> fix this. However, we can push out to 2.30 if we want.
>>
>> We can hold off till 23rd for the hard freeze; would that be enough time
>> for you? That gives me enough time to run tests over the weekend and do
>> the release the following week.
>>
>> That should also give HJ enough time to fix the x32 bug he just found.
>
> Carlos, HJ, are we doing OK for time? Would you be OK for a hard freeze
> by the end of this week, i.e. Sunday? That will give me all of next
> week to run final tests for the release.
>
> How's the strftime change doing? It looks like y'all are on the last
> couple of patches now.
>
> As for the ChangeLog script, I've worked on incorporating it into gnulib
> and am targeting end of my day tomorrow to post a patch for review on
> the gnulib ML. I believe we are on target for dropping the ChangeLog
> requirement for 2.30 development, so I'll be requesting review of wiki
> changes next week indicating the change in workflow.
I just posed the complete rwlock fix with regression tests:
https://www.sourceware.org/ml/libc-alpha/2019-01/msg00557.html
Analysis with execution ordering showing failures:
https://sourceware.org/bugzilla/show_bug.cgi?id=23844#c14
I don't expect anyone to give substantive review. Torvald was the
expert, and he mostly wrote the patch with input from Rik Prohaska.
I basically did the review, and created the test cases from my own
review, and carried out testing on x86_64 to determine how fast the
stall can be triggered (to set test timeouts and sleeps). Reviewing
this requires a complete understanding of the new rwlock algorithm.
However, at this point it is much better than the stalls we have and
so it should go in ASAP.
I expect to commit the fix as soon as Torvald and Rik let me use
their Signed-off-by.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2019-01-22 4:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 14:37 2.29 freeze update: Last fortnight Siddhesh Poyarekar
2019-01-15 16:52 ` Rafal Luzynski
2019-01-15 17:02 ` Zack Weinberg
2019-01-15 17:16 ` Rafal Luzynski
2019-01-15 17:49 ` Paul Eggert
2019-01-15 18:16 ` Rafal Luzynski
2019-01-15 18:22 ` Paul Eggert
2019-01-15 22:03 ` Rafal Luzynski
2019-01-15 17:09 ` Carlos O'Donell
2019-01-17 6:30 ` TAMUKI Shoichi
2019-01-17 6:29 ` TAMUKI Shoichi
2019-01-17 20:32 ` Rafal Luzynski
2019-01-18 13:58 ` TAMUKI Shoichi
2019-01-18 15:35 ` Rafal Luzynski
2019-01-15 20:09 ` Jochen Hein
2019-01-16 3:44 ` Siddhesh Poyarekar
2019-01-15 20:17 ` Carlos O'Donell
2019-01-16 3:47 ` Siddhesh Poyarekar
2019-01-22 3:28 ` Siddhesh Poyarekar
2019-01-22 3:52 ` H.J. Lu
2019-01-22 22:14 ` Joseph Myers
2019-01-22 4:21 ` Carlos O'Donell [this message]
2019-01-22 12:00 ` Florian Weimer
2019-01-22 13:06 ` Carlos O'Donell
2019-01-22 13:11 ` Szabolcs Nagy
2019-01-22 13:23 ` Carlos O'Donell
2019-01-22 15:17 ` Siddhesh Poyarekar
2019-01-22 15:48 ` Carlos O'Donell
2019-01-22 16:06 ` DCO or Copyright Assignment? Why not both Siddhesh Poyarekar
2019-01-28 13:00 ` Florian Weimer
2019-01-22 10:18 ` 2.29 freeze update: Last fortnight Rafal Luzynski
2019-01-16 3:13 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44bd049f-b6c9-45f8-14fc-f56f54f3e1d6@redhat.com \
--to=carlos@redhat.com \
--cc=digitalfreak@lingonborough.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).