From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5BA861F453 for ; Tue, 22 Jan 2019 04:21:53 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=LIvhW51+cyrWkbbs PqoS40wSIM0D/19E0l49liCTaWhSleFQoMA9qQyeqgjXimYemSh35tXjqw7WvSlZ l2oaF8WkQgxxzl0lfAQaysarqh/OqTljOm7bP1seOHl8Y5yzo7/mB4KHj+Gfqh1U 99xPAyYIT9XqURKTp5qnOwIil7s= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=LGb8mctfStqND2zXjLs9ZL BX65s=; b=vUhdJr4oI1Fnbw2WVPx7SMbIab1EtV+yBeWQFQLbPBXxvV9GD1z1Dv Z+HrNrtrnx+3c37gXOhNVtBG4iJpCDrpQuMVZZa5+plBP+LM++5HeFQZCFVQUeqV 70bWv/1IHJsi5XLW2cO0iSP/0JZ9Ja1Ltvk58kNCJ3g6Rs0NIOkd0= Received: (qmail 51547 invoked by alias); 22 Jan 2019 04:21:51 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 51530 invoked by uid 89); 22 Jan 2019 04:21:50 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qt1-f169.google.com Subject: Re: 2.29 freeze update: Last fortnight To: Siddhesh Poyarekar , GLIBC Devel Cc: Rafal Luzynski , Joseph Myers References: <05ad17bc-be3b-5bfb-a80b-6f2a85528974@gotplt.org> <5532615b-08e3-adfa-d44d-e3bb0232829e@gotplt.org> <21e0277e-9b46-75b8-12d8-47464717e2f0@gotplt.org> From: Carlos O'Donell Openpgp: preference=signencrypt Message-ID: <44bd049f-b6c9-45f8-14fc-f56f54f3e1d6@redhat.com> Date: Mon, 21 Jan 2019 23:21:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <21e0277e-9b46-75b8-12d8-47464717e2f0@gotplt.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 1/21/19 10:28 PM, Siddhesh Poyarekar wrote: > On 16/01/19 9:17 AM, Siddhesh Poyarekar wrote: >> On 16/01/19 1:47 AM, Carlos O'Donell wrote: >>> I'm working at trying to fix the rwlock bug. I'd like to see the bug >>> fix included in the release. I think I need the rest of the week to >>> fix this. However, we can push out to 2.30 if we want. >> >> We can hold off till 23rd for the hard freeze; would that be enough time >> for you?  That gives me enough time to run tests over the weekend and do >> the release the following week. >> >> That should also give HJ enough time to fix the x32 bug he just found. > > Carlos, HJ, are we doing OK for time? Would you be OK for a hard freeze > by the end of this week, i.e. Sunday? That will give me all of next > week to run final tests for the release. > > How's the strftime change doing? It looks like y'all are on the last > couple of patches now. > > As for the ChangeLog script, I've worked on incorporating it into gnulib > and am targeting end of my day tomorrow to post a patch for review on > the gnulib ML. I believe we are on target for dropping the ChangeLog > requirement for 2.30 development, so I'll be requesting review of wiki > changes next week indicating the change in workflow. I just posed the complete rwlock fix with regression tests: https://www.sourceware.org/ml/libc-alpha/2019-01/msg00557.html Analysis with execution ordering showing failures: https://sourceware.org/bugzilla/show_bug.cgi?id=23844#c14 I don't expect anyone to give substantive review. Torvald was the expert, and he mostly wrote the patch with input from Rik Prohaska. I basically did the review, and created the test cases from my own review, and carried out testing on x86_64 to determine how fast the stall can be triggered (to set test timeouts and sleeps). Reviewing this requires a complete understanding of the new rwlock algorithm. However, at this point it is much better than the stalls we have and so it should go in ASAP. I expect to commit the fix as soon as Torvald and Rik let me use their Signed-off-by. -- Cheers, Carlos.