* [PATCH COMMITTED] MIPS: Fix circular definition of __LDBL_MANT_DIG__ in ieee754.h
@ 2020-01-08 19:39 Zack Weinberg
0 siblings, 0 replies; only message in thread
From: Zack Weinberg @ 2020-01-08 19:39 UTC (permalink / raw)
To: libc-alpha
In commit aa706e13f4bfdf32a27c498902edf4f6006e433e,
sysdeps/mips/ieee754/ieee754.h was changed to use GCC’s predefined
macro __LDBL_MANT_DIG__, instead of including <float.h> and using
LDBL_MANT_DIG (and therefore polluting the user namespace with all of
the macros defined in float.h). In order to support compilers that
don’t provide __LDBL_MANT_DIG__, there is a fallback #if block which
was supposed to include <float.h> and then define __LDBL_MANT_DIG__ to
LDBL_MANT_DIG. However, at some point during the development of the
patch, a typo was introduced, causing the fallback block to define
__LDBL_MANT_DIG__ to expand to __LDBL_MANT_DIG__.
Correct this typo.
---
Since this is an obvious typo fix and time before the release is short,
I have already pushed this patch to master.
zw
---
sysdeps/mips/ieee754/ieee754.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/mips/ieee754/ieee754.h b/sysdeps/mips/ieee754/ieee754.h
index 75059f733b..62f17586f1 100644
--- a/sysdeps/mips/ieee754/ieee754.h
+++ b/sysdeps/mips/ieee754/ieee754.h
@@ -24,7 +24,7 @@
#ifndef __LDBL_MANT_DIG__
# include <float.h>
-# define __LDBL_MANT_DIG__ __LDBL_MANT_DIG__
+# define __LDBL_MANT_DIG__ LDBL_MANT_DIG
#endif
__BEGIN_DECLS
--
2.25.0.rc1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-01-08 19:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 19:39 [PATCH COMMITTED] MIPS: Fix circular definition of __LDBL_MANT_DIG__ in ieee754.h Zack Weinberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).