From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C5EDF1F463 for ; Wed, 8 Jan 2020 19:39:19 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=default; b=G/0 s0r6Pu5T/ypEAkJkHM37YleLzqAuWZI+ZcAuJYz7EMWFZ0ZwCeDXujZX+JHU7TjS zVTS4r8MKFC6h3YDbRfBYyKZDuEowmAyY5KGu1sE8SNPfLQ8199MH3QMPsZ/uRg6 DljXJmK8e5SanhpAPAMpLn0WWrdisJe/6F4n/n7c= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type:content-transfer-encoding; s=default; bh=5paAhHkZv 51Y0hot5Z9OAAOk08o=; b=o6l6PgkGFGnkidJoqj6q+3MuvoyiAEgKUOKK6hgs0 YMn8urGtRxrzlzABgy5Js/umkeAUk85K3ZWofYuIXes1C44Yof5beggsnCMQ9VI1 47V+gmsEux2rQ7l9ifWxksiH2y8sH9SZpqRRbpEU71BPFY1YyKkZnqw8v70COxbb pE= Received: (qmail 9214 invoked by alias); 8 Jan 2020 19:39:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 9201 invoked by uid 89); 8 Jan 2020 19:39:16 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mailbackend.panix.com From: Zack Weinberg To: libc-alpha@sourceware.org Subject: [PATCH COMMITTED] MIPS: Fix circular definition of __LDBL_MANT_DIG__ in ieee754.h Date: Wed, 8 Jan 2020 14:39:13 -0500 Message-Id: <20200108193913.25388-1-zackw@panix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In commit aa706e13f4bfdf32a27c498902edf4f6006e433e, sysdeps/mips/ieee754/ieee754.h was changed to use GCC’s predefined macro __LDBL_MANT_DIG__, instead of including and using LDBL_MANT_DIG (and therefore polluting the user namespace with all of the macros defined in float.h). In order to support compilers that don’t provide __LDBL_MANT_DIG__, there is a fallback #if block which was supposed to include and then define __LDBL_MANT_DIG__ to LDBL_MANT_DIG. However, at some point during the development of the patch, a typo was introduced, causing the fallback block to define __LDBL_MANT_DIG__ to expand to __LDBL_MANT_DIG__. Correct this typo. --- Since this is an obvious typo fix and time before the release is short, I have already pushed this patch to master. zw --- sysdeps/mips/ieee754/ieee754.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/mips/ieee754/ieee754.h b/sysdeps/mips/ieee754/ieee754.h index 75059f733b..62f17586f1 100644 --- a/sysdeps/mips/ieee754/ieee754.h +++ b/sysdeps/mips/ieee754/ieee754.h @@ -24,7 +24,7 @@ #ifndef __LDBL_MANT_DIG__ # include -# define __LDBL_MANT_DIG__ __LDBL_MANT_DIG__ +# define __LDBL_MANT_DIG__ LDBL_MANT_DIG #endif __BEGIN_DECLS -- 2.25.0.rc1