unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / code / Atom feed
* [PATCH v2] NEWS: Mention renamed libresolv symbols moved into libc
@ 2021-07-21 13:28 Florian Weimer via Libc-alpha
  2021-07-29  2:23 ` Carlos O'Donell via Libc-alpha
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer via Libc-alpha @ 2021-07-21 13:28 UTC (permalink / raw)
  To: libc-alpha

---
 NEWS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/NEWS b/NEWS
index 4df348cce5..8f80a35bbe 100644
--- a/NEWS
+++ b/NEWS
@@ -107,6 +107,13 @@ Deprecated and removed features, and other changes affecting compatibility:
   ns_format_ttl, ns_makecanon, ns_parse_ttl, ns_samedomain, ns_samename,
   ns_sprintrr, ns_sprintrrf, ns_subdomain have been deprecated.
 
+* The symbols __dn_comp, __dn_expand, __dn_skipname, __res_dnok,
+  __res_hnok, __res_mailok, __res_mkquery, __res_nmkquery, __res_nquery,
+  __res_nquerydomain, __res_nsearch, __res_nsend, __res_ownok,
+  __res_query, __res_querydomain, __res_search, __res_send formerly in
+  libresolv have been renamed and no longer have a __ prefix.  They are
+  now available in libc.
+
 * The pthread cancellation handler is now installed with SA_RESTART and
   pthread_cancel will always send the internal SIGCANCEL on a cancellation
   request.  It should not be visible to application since the cancellation


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] NEWS: Mention renamed libresolv symbols moved into libc
  2021-07-21 13:28 [PATCH v2] NEWS: Mention renamed libresolv symbols moved into libc Florian Weimer via Libc-alpha
@ 2021-07-29  2:23 ` Carlos O'Donell via Libc-alpha
  0 siblings, 0 replies; 2+ messages in thread
From: Carlos O'Donell via Libc-alpha @ 2021-07-29  2:23 UTC (permalink / raw)
  To: Florian Weimer, libc-alpha

On 7/21/21 9:28 AM, Florian Weimer via Libc-alpha wrote:
> ---
>  NEWS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/NEWS b/NEWS
> index 4df348cce5..8f80a35bbe 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -107,6 +107,13 @@ Deprecated and removed features, and other changes affecting compatibility:
>    ns_format_ttl, ns_makecanon, ns_parse_ttl, ns_samedomain, ns_samename,
>    ns_sprintrr, ns_sprintrrf, ns_subdomain have been deprecated.
>  
> +* The symbols __dn_comp, __dn_expand, __dn_skipname, __res_dnok,
> +  __res_hnok, __res_mailok, __res_mkquery, __res_nmkquery, __res_nquery,
> +  __res_nquerydomain, __res_nsearch, __res_nsend, __res_ownok,
> +  __res_query, __res_querydomain, __res_search, __res_send formerly in
> +  libresolv have been renamed and no longer have a __ prefix.  They are
> +  now available in libc.

This needs a reason statement. The previous paragraph has a good example
of this e.g. "Various rarely-used functions ... have been deprecated."

We need a reason here like:

* Various symbols previously defined in libresolv have been moved to libc
  in order to prepare for libresolv moving entirely into libc (see earlier
  entry for merging libraries into libc). ...

Looking forward to a v2.

> +
>  * The pthread cancellation handler is now installed with SA_RESTART and
>    pthread_cancel will always send the internal SIGCANCEL on a cancellation
>    request.  It should not be visible to application since the cancellation
> 


-- 
Cheers,
Carlos.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-29  2:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 13:28 [PATCH v2] NEWS: Mention renamed libresolv symbols moved into libc Florian Weimer via Libc-alpha
2021-07-29  2:23 ` Carlos O'Donell via Libc-alpha

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/glibc.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).