unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v2] NEWS: Mention renamed libresolv symbols moved into libc
Date: Wed, 28 Jul 2021 22:23:05 -0400	[thread overview]
Message-ID: <06f15f88-cb71-494a-6c80-e1d698d1efa4@redhat.com> (raw)
In-Reply-To: <874kcnn6d7.fsf@oldenburg.str.redhat.com>

On 7/21/21 9:28 AM, Florian Weimer via Libc-alpha wrote:
> ---
>  NEWS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/NEWS b/NEWS
> index 4df348cce5..8f80a35bbe 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -107,6 +107,13 @@ Deprecated and removed features, and other changes affecting compatibility:
>    ns_format_ttl, ns_makecanon, ns_parse_ttl, ns_samedomain, ns_samename,
>    ns_sprintrr, ns_sprintrrf, ns_subdomain have been deprecated.
>  
> +* The symbols __dn_comp, __dn_expand, __dn_skipname, __res_dnok,
> +  __res_hnok, __res_mailok, __res_mkquery, __res_nmkquery, __res_nquery,
> +  __res_nquerydomain, __res_nsearch, __res_nsend, __res_ownok,
> +  __res_query, __res_querydomain, __res_search, __res_send formerly in
> +  libresolv have been renamed and no longer have a __ prefix.  They are
> +  now available in libc.

This needs a reason statement. The previous paragraph has a good example
of this e.g. "Various rarely-used functions ... have been deprecated."

We need a reason here like:

* Various symbols previously defined in libresolv have been moved to libc
  in order to prepare for libresolv moving entirely into libc (see earlier
  entry for merging libraries into libc). ...

Looking forward to a v2.

> +
>  * The pthread cancellation handler is now installed with SA_RESTART and
>    pthread_cancel will always send the internal SIGCANCEL on a cancellation
>    request.  It should not be visible to application since the cancellation
> 


-- 
Cheers,
Carlos.


      reply	other threads:[~2021-07-29  2:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 13:28 [PATCH v2] NEWS: Mention renamed libresolv symbols moved into libc Florian Weimer via Libc-alpha
2021-07-29  2:23 ` Carlos O'Donell via Libc-alpha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06f15f88-cb71-494a-6c80-e1d698d1efa4@redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=carlos@redhat.com \
    --cc=fweimer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).