From: Junio C Hamano <gitster@pobox.com>
To: Fredrik Medley <fredrik.medley@gmail.com>
Cc: git@vger.kernel.org,
Christian Halstrick <christian.halstrick@gmail.com>,
Dan Johnson <computerdruid@gmail.com>, Jeff King <peff@peff.net>,
Jonathan Nieder <jrnieder@gmail.com>,
Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want
Date: Tue, 19 May 2015 15:00:44 -0700 [thread overview]
Message-ID: <xmqqzj505isz.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1432068269-14895-2-git-send-email-fredrik.medley@gmail.com> (Fredrik Medley's message of "Tue, 19 May 2015 22:44:28 +0200")
Fredrik Medley <fredrik.medley@gmail.com> writes:
> static int upload_pack_config(const char *var, const char *value, void *unused)
> {
> - if (!strcmp("uploadpack.allowtipsha1inwant", var))
> - allow_tip_sha1_in_want = git_config_bool(var, value);
> - else if (!strcmp("uploadpack.keepalive", var)) {
> + if (!strcmp("uploadpack.allowtipsha1inwant", var)) {
> + if (git_config_bool(var, value))
> + allow_unadvertised_object_request |= ALLOW_TIP_SHA1;
Doesn't this change break the behaviour?
Shouldn't you be able to say
[uploadpack]
allowTipSHA1InWant = false
in a higher-precedence configuration file to override the same
variable in other files in the configuration chain that may set it
to true?
> + } else if (!strcmp("uploadpack.keepalive", var)) {
> keepalive = git_config_int(var, value);
> if (!keepalive)
> keepalive = -1;
next prev parent reply other threads:[~2015-05-19 22:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 22:01 [PATCH] upload-pack: Optionally allow fetching reachable sha1 Fredrik Medley
2015-05-03 17:40 ` Junio C Hamano
2015-05-03 20:13 ` Fredrik Medley
2015-05-03 21:35 ` Eric Sunshine
2015-05-05 21:21 ` [PATCH v2] " Fredrik Medley
2015-05-05 22:16 ` Junio C Hamano
2015-05-06 20:10 ` Fredrik Medley
2015-05-06 20:19 ` Junio C Hamano
2015-05-12 21:14 ` [PATCH 1/3] config.txt: Clarify allowTipSHA1InWant with camelCase Fredrik Medley
2015-05-12 21:14 ` [PATCH 2/3] upload-pack: Prepare to extend allow-tip-sha1-in-want Fredrik Medley
2015-05-12 21:37 ` Eric Sunshine
2015-05-12 21:39 ` Junio C Hamano
2015-05-19 20:19 ` Fredrik Medley
2015-05-12 21:14 ` [PATCH 3/3] upload-pack: Optionally allow fetching reachable sha1 Fredrik Medley
2015-05-12 22:01 ` Eric Sunshine
2015-05-19 20:44 ` [PATCH 1/3] config.txt: clarify allowTipSHA1InWant with camelCase Fredrik Medley
2015-05-19 20:44 ` [PATCH 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want Fredrik Medley
2015-05-19 22:00 ` Junio C Hamano [this message]
2015-05-20 19:31 ` Fredrik Medley
2015-05-19 20:44 ` [PATCH 3/3] upload-pack: optionally allow fetching reachable sha1 Fredrik Medley
2015-05-19 22:06 ` Junio C Hamano
2015-05-21 20:23 ` [PATCH v5 1/3] config.txt: clarify allowTipSHA1InWant with camelCase Fredrik Medley
2015-05-21 20:23 ` [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want Fredrik Medley
2015-05-21 22:07 ` Junio C Hamano
2015-05-22 23:47 ` Fredrik Medley
2015-05-23 0:53 ` Junio C Hamano
2015-05-21 20:23 ` [PATCH v5 3/3] upload-pack: optionally allow fetching reachable sha1 Fredrik Medley
2015-05-21 22:15 ` Junio C Hamano
2015-05-22 23:55 ` Fredrik Medley
2015-05-23 1:01 ` Junio C Hamano
2015-05-12 21:24 ` [PATCH 1/3] config.txt: Clarify allowTipSHA1InWant with camelCase Eric Sunshine
2015-05-12 21:33 ` Junio C Hamano
2015-05-12 21:35 ` Junio C Hamano
2015-05-05 22:29 ` [PATCH v2] upload-pack: Optionally allow fetching reachable sha1 Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzj505isz.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=christian.halstrick@gmail.com \
--cc=computerdruid@gmail.com \
--cc=fredrik.medley@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).