From: Eric Sunshine <sunshine@sunshineco.com>
To: Fredrik Medley <fredrik.medley@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Christian Halstrick <christian.halstrick@gmail.com>,
Dan Johnson <computerdruid@gmail.com>, Jeff King <peff@peff.net>,
Jonathan Nieder <jrnieder@gmail.com>,
Duy Nguyen <pclouds@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] upload-pack: Optionally allow fetching reachable sha1
Date: Tue, 5 May 2015 18:29:00 -0400 [thread overview]
Message-ID: <CAPig+cRqDdj0fHdt10x_YhZcEdJ9WN_bAjUH5MjQxKhdVaEKGg@mail.gmail.com> (raw)
In-Reply-To: <1430860888-6146-1-git-send-email-fredrik.medley@gmail.com>
On Tue, May 5, 2015 at 5:21 PM, Fredrik Medley <fredrik.medley@gmail.com> wrote:
> With uploadpack.allowreachablesha1inwant configuration option set on the
> server side, "git fetch" can make a request with a "want" line that names
> an object that has not been advertised (likely to have been obtained out
> of band or from a submodule pointer). Only objects reachable from the
> branch tips, i.e. the union of advertised branches and branches hidden by
> transfer.hiderefs, will be processed. Note that there is an associated
> cost of having to walk back the hstory to check the reachability.
> [...]
> Signed-off-by: Fredrik Medley <fredrik.medley@gmail.com>
> ---
> diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
> index 8a5f236..01fabfb 100755
> --- a/t/t5516-fetch-push.sh
> +++ b/t/t5516-fetch-push.sh
> @@ -1120,6 +1120,61 @@ test_expect_success 'fetch exact SHA1' '
> )
> '
>
> +for configallowtipsha1inwant in true false
> +do
> + test_expect_success "shallow fetch reachable SHA1 (but not a ref), allowtipsha1inwant=$configallowtipsha1inwant" '
> + mk_empty testrepo &&
> + (
> + cd testrepo &&
> + git config uploadpack.allowtipsha1inwant $configallowtipsha1inwant &&
> + git commit --allow-empty -m foo &&
> + git commit --allow-empty -m bar
> + ) &&
> + SHA1=`git --git-dir=testrepo/.git rev-parse HEAD^` &&
Use $(..) here and elsewhere rather than `...`.
SHA1=$(git --git-dir=testrepo/.git rev-parse HEAD^) &&
> + mk_empty shallow &&
> + (
> + cd shallow &&
> + test_must_fail git fetch --depth=1 ../testrepo/.git $SHA1 &&
> + git --git-dir=../testrepo/.git config uploadpack.allowreachablesha1inwant true &&
> + git fetch --depth=1 ../testrepo/.git $SHA1 &&
> + git cat-file commit $SHA1 >/dev/null
> + )
> + '
> +
> + test_expect_success "deny fetch unreachable SHA1, allowtipsha1inwant=$configallowtipsha1inwant" '
> + mk_empty testrepo &&
> + (
> + cd testrepo &&
> + git config uploadpack.allowtipsha1inwant $configallowtipsha1inwant &&
> + git commit --allow-empty -m foo &&
> + git commit --allow-empty -m bar &&
> + git commit --allow-empty -m xyz
> + )
> + SHA1_1=`git --git-dir=testrepo/.git rev-parse HEAD^^` &&
> + SHA1_2=`git --git-dir=testrepo/.git rev-parse HEAD^` &&
> + SHA1_3=`git --git-dir=testrepo/.git rev-parse HEAD` &&
> + (
> + cd testrepo &&
> + git reset --hard $SHA1_2 &&
> + git cat-file commit $SHA1_3 >/dev/null &&
> + git cat-file commit $SHA1_3 >/dev/null
> + ) &&
> + mk_empty shallow &&
> + (
> + cd shallow &&
> + test_must_fail git fetch ../testrepo/.git $SHA1_3 &&
> + test_must_fail git fetch ../testrepo/.git $SHA1_1 &&
> + git --git-dir=../testrepo/.git config uploadpack.allowreachablesha1inwant true &&
> + git fetch ../testrepo/.git $SHA1_1 &&
> + git cat-file commit $SHA1_1 >/dev/null &&
> + test_must_fail git cat-file commit $SHA1_2 >/dev/null &&
> + git fetch ../testrepo/.git $SHA1_2 &&
> + git cat-file commit $SHA1_2 >/dev/null &&
> + test_must_fail git fetch ../testrepo/.git $SHA1_3
> + )
> + '
> +done
> +
> test_expect_success 'fetch follows tags by default' '
> mk_test testrepo heads/master &&
> rm -fr src dst &&
prev parent reply other threads:[~2015-05-05 22:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 22:01 [PATCH] upload-pack: Optionally allow fetching reachable sha1 Fredrik Medley
2015-05-03 17:40 ` Junio C Hamano
2015-05-03 20:13 ` Fredrik Medley
2015-05-03 21:35 ` Eric Sunshine
2015-05-05 21:21 ` [PATCH v2] " Fredrik Medley
2015-05-05 22:16 ` Junio C Hamano
2015-05-06 20:10 ` Fredrik Medley
2015-05-06 20:19 ` Junio C Hamano
2015-05-12 21:14 ` [PATCH 1/3] config.txt: Clarify allowTipSHA1InWant with camelCase Fredrik Medley
2015-05-12 21:14 ` [PATCH 2/3] upload-pack: Prepare to extend allow-tip-sha1-in-want Fredrik Medley
2015-05-12 21:37 ` Eric Sunshine
2015-05-12 21:39 ` Junio C Hamano
2015-05-19 20:19 ` Fredrik Medley
2015-05-12 21:14 ` [PATCH 3/3] upload-pack: Optionally allow fetching reachable sha1 Fredrik Medley
2015-05-12 22:01 ` Eric Sunshine
2015-05-19 20:44 ` [PATCH 1/3] config.txt: clarify allowTipSHA1InWant with camelCase Fredrik Medley
2015-05-19 20:44 ` [PATCH 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want Fredrik Medley
2015-05-19 22:00 ` Junio C Hamano
2015-05-20 19:31 ` Fredrik Medley
2015-05-19 20:44 ` [PATCH 3/3] upload-pack: optionally allow fetching reachable sha1 Fredrik Medley
2015-05-19 22:06 ` Junio C Hamano
2015-05-21 20:23 ` [PATCH v5 1/3] config.txt: clarify allowTipSHA1InWant with camelCase Fredrik Medley
2015-05-21 20:23 ` [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want Fredrik Medley
2015-05-21 22:07 ` Junio C Hamano
2015-05-22 23:47 ` Fredrik Medley
2015-05-23 0:53 ` Junio C Hamano
2015-05-21 20:23 ` [PATCH v5 3/3] upload-pack: optionally allow fetching reachable sha1 Fredrik Medley
2015-05-21 22:15 ` Junio C Hamano
2015-05-22 23:55 ` Fredrik Medley
2015-05-23 1:01 ` Junio C Hamano
2015-05-12 21:24 ` [PATCH 1/3] config.txt: Clarify allowTipSHA1InWant with camelCase Eric Sunshine
2015-05-12 21:33 ` Junio C Hamano
2015-05-12 21:35 ` Junio C Hamano
2015-05-05 22:29 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRqDdj0fHdt10x_YhZcEdJ9WN_bAjUH5MjQxKhdVaEKGg@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=christian.halstrick@gmail.com \
--cc=computerdruid@gmail.com \
--cc=fredrik.medley@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).