From: Eric Sunshine <sunshine@sunshineco.com>
To: Fredrik Medley <fredrik.medley@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Christian Halstrick <christian.halstrick@gmail.com>,
Dan Johnson <computerdruid@gmail.com>, Jeff King <peff@peff.net>,
Jonathan Nieder <jrnieder@gmail.com>,
Duy Nguyen <pclouds@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/3] config.txt: Clarify allowTipSHA1InWant with camelCase
Date: Tue, 12 May 2015 17:24:06 -0400 [thread overview]
Message-ID: <CAPig+cTc7qE_tD2-DtpnMGrSFthwaGakFnOWAtkq=a5aOQNMbQ@mail.gmail.com> (raw)
In-Reply-To: <1431465265-18486-1-git-send-email-fredrik.medley@gmail.com>
On Tue, May 12, 2015 at 5:14 PM, Fredrik Medley
<fredrik.medley@gmail.com> wrote:
> Most of the options in config.txt are camelCase. Improve the readability
> for allowtipsha1inwant by changing to allowTipSHA1InWant.
Missing sign-off. More below.
> ---
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 2e5ceaf..2b86fe6 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -2530,9 +2530,9 @@ uploadpack.hideRefs::
> are under the hierarchies listed on the value of this
> variable is excluded, and is hidden from `git ls-remote`,
> `git fetch`, etc. An attempt to fetch a hidden ref by `git
> - fetch` will fail. See also `uploadpack.allowtipsha1inwant`.
> + fetch` will fail. See also `uploadpack.allowTipSHA1InWant`.
>
> -uploadpack.allowtipsha1inwant::
> +uploadpack.allowTipSHA1InWant::
This was already attempted here[1]; some inconsistencies with acronyms
and abbreviations pointed out here[2]; and delayed here[3]. Perhaps
it's now time to revisit the acronyms/abbreviations issue?
[1]: http://thread.gmane.org/gmane.comp.version-control.git/265225/focus=265225
[2]: http://thread.gmane.org/gmane.comp.version-control.git/265225/focus=265262
[3]: http://thread.gmane.org/gmane.comp.version-control.git/265225/focus=265282
> When `uploadpack.hideRefs` is in effect, allow `upload-pack`
> to accept a fetch request that asks for an object at the tip
> of a hidden ref (by default, such a request is rejected).
> --
> 1.9.1
next prev parent reply other threads:[~2015-05-12 21:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 22:01 [PATCH] upload-pack: Optionally allow fetching reachable sha1 Fredrik Medley
2015-05-03 17:40 ` Junio C Hamano
2015-05-03 20:13 ` Fredrik Medley
2015-05-03 21:35 ` Eric Sunshine
2015-05-05 21:21 ` [PATCH v2] " Fredrik Medley
2015-05-05 22:16 ` Junio C Hamano
2015-05-06 20:10 ` Fredrik Medley
2015-05-06 20:19 ` Junio C Hamano
2015-05-12 21:14 ` [PATCH 1/3] config.txt: Clarify allowTipSHA1InWant with camelCase Fredrik Medley
2015-05-12 21:14 ` [PATCH 2/3] upload-pack: Prepare to extend allow-tip-sha1-in-want Fredrik Medley
2015-05-12 21:37 ` Eric Sunshine
2015-05-12 21:39 ` Junio C Hamano
2015-05-19 20:19 ` Fredrik Medley
2015-05-12 21:14 ` [PATCH 3/3] upload-pack: Optionally allow fetching reachable sha1 Fredrik Medley
2015-05-12 22:01 ` Eric Sunshine
2015-05-19 20:44 ` [PATCH 1/3] config.txt: clarify allowTipSHA1InWant with camelCase Fredrik Medley
2015-05-19 20:44 ` [PATCH 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want Fredrik Medley
2015-05-19 22:00 ` Junio C Hamano
2015-05-20 19:31 ` Fredrik Medley
2015-05-19 20:44 ` [PATCH 3/3] upload-pack: optionally allow fetching reachable sha1 Fredrik Medley
2015-05-19 22:06 ` Junio C Hamano
2015-05-21 20:23 ` [PATCH v5 1/3] config.txt: clarify allowTipSHA1InWant with camelCase Fredrik Medley
2015-05-21 20:23 ` [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want Fredrik Medley
2015-05-21 22:07 ` Junio C Hamano
2015-05-22 23:47 ` Fredrik Medley
2015-05-23 0:53 ` Junio C Hamano
2015-05-21 20:23 ` [PATCH v5 3/3] upload-pack: optionally allow fetching reachable sha1 Fredrik Medley
2015-05-21 22:15 ` Junio C Hamano
2015-05-22 23:55 ` Fredrik Medley
2015-05-23 1:01 ` Junio C Hamano
2015-05-12 21:24 ` Eric Sunshine [this message]
2015-05-12 21:33 ` [PATCH 1/3] config.txt: Clarify allowTipSHA1InWant with camelCase Junio C Hamano
2015-05-12 21:35 ` Junio C Hamano
2015-05-05 22:29 ` [PATCH v2] upload-pack: Optionally allow fetching reachable sha1 Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTc7qE_tD2-DtpnMGrSFthwaGakFnOWAtkq=a5aOQNMbQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=christian.halstrick@gmail.com \
--cc=computerdruid@gmail.com \
--cc=fredrik.medley@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).