From: Junio C Hamano <gitster@pobox.com>
To: Chen Bin <chenbin.sh@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/1] Add the `p4-pre-submit` hook
Date: Wed, 01 Aug 2018 10:41:54 -0700 [thread overview]
Message-ID: <xmqqzhy66l25.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180801155432.4041-1-chenbin.sh@gmail.com> (Chen Bin's message of "Thu, 2 Aug 2018 01:54:32 +1000")
Chen Bin <chenbin.sh@gmail.com> writes:
> The `p4-pre-submit` hook is executed before git-p4 submits code.
> If the hook exits with non-zero value, submit process won't start.
>
> Signed-off-by: Chen Bin <chenbin.sh@gmail.com>
> ---
I see that the only difference between this and what has been queued
on 'pu', i.e.
https://github.com/gitster/git/commit/fb78b040c5dc5b80a093d028d13f8cd32ade17cd
is that this is missing the update in
https://public-inbox.org/git/xmqq1sbkfneo.fsf@gitster-ct.c.googlers.com/
and also Luke's "Reviewed-by:".
I recall that you had trouble getting "git p4" in the test (not
"git-p4") working for some reason. Has that been resolved (iow
have you figured out why it was failing?)
Thanks.
prev parent reply other threads:[~2018-08-01 17:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 11:27 [PATCH 1/1] add hook pre-p4-submit Chen Bin
2018-07-25 8:37 ` Luke Diamand
2018-07-25 9:14 ` Ævar Arnfjörð Bjarmason
2018-07-25 11:10 ` chen bin
2018-07-25 13:43 ` Chen Bin
2018-07-25 20:00 ` Eric Sunshine
2018-07-25 20:21 ` Junio C Hamano
2018-07-26 2:08 ` chen bin
2018-07-26 9:21 ` Eric Sunshine
2018-07-26 21:09 ` Luke Diamand
2018-07-27 1:31 ` chen bin
2018-07-26 13:41 ` Chen Bin
2018-07-26 16:49 ` Junio C Hamano
2018-07-26 21:20 ` Eric Sunshine
2018-07-27 11:22 ` [PATCH 1/1] Add the `p4-pre-submit` hook Chen Bin
2018-07-27 18:15 ` Eric Sunshine
2018-07-30 18:07 ` Junio C Hamano
2018-07-30 18:48 ` Luke Diamand
2018-07-30 21:01 ` Junio C Hamano
2018-07-31 8:46 ` SZEDER Gábor
2018-07-31 13:40 ` Luke Diamand
2018-07-31 14:40 ` Junio C Hamano
2018-07-31 19:54 ` Luke Diamand
2018-08-01 14:57 ` chen bin
2018-08-01 15:10 ` Junio C Hamano
2018-08-01 15:54 ` Chen Bin
2018-08-01 17:41 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzhy66l25.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=chenbin.sh@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).