From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: bin chen <chenbin.sh@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/1] add hook pre-p4-submit
Date: Thu, 26 Jul 2018 17:20:17 -0400 [thread overview]
Message-ID: <CAPig+cQQmOpEpUNSjw58b-_+Ep3v0XA+vuqqqgHVOaFgtKt3fA@mail.gmail.com> (raw)
In-Reply-To: <xmqq36w6rlh7.fsf@gitster-ct.c.googlers.com>
On Thu, Jul 26, 2018 at 12:49 PM Junio C Hamano <gitster@pobox.com> wrote:
> Chen Bin <chenbin.sh@gmail.com> writes:
> > + git p4 submit --dry-run >out && grep "Would apply" out || echo "Abort submit"
>
> What is this last "|| echo I always succeed" about?
>
> Do you want to make sure "git p4 submit" exit with non-zero exit
> status *and* its output does not say "Would apply"? The way to
> write that would be
>
> test_must_fail git p4 submit --dry-run >out &&
> ! grep "Would apply" out
I missed the 'test_must_fail' when I suggested this same rewrite[1],
which may explain why the suggestion wasn't used in the re-roll.
Sorry.
[1]: https://public-inbox.org/git/CAPig+cR2gYEwOTVBMRde35rn9oVsixeerbm5iJV+FmnOiBWxqQ@mail.gmail.com/
next prev parent reply other threads:[~2018-07-26 21:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 11:27 [PATCH 1/1] add hook pre-p4-submit Chen Bin
2018-07-25 8:37 ` Luke Diamand
2018-07-25 9:14 ` Ævar Arnfjörð Bjarmason
2018-07-25 11:10 ` chen bin
2018-07-25 13:43 ` Chen Bin
2018-07-25 20:00 ` Eric Sunshine
2018-07-25 20:21 ` Junio C Hamano
2018-07-26 2:08 ` chen bin
2018-07-26 9:21 ` Eric Sunshine
2018-07-26 21:09 ` Luke Diamand
2018-07-27 1:31 ` chen bin
2018-07-26 13:41 ` Chen Bin
2018-07-26 16:49 ` Junio C Hamano
2018-07-26 21:20 ` Eric Sunshine [this message]
2018-07-27 11:22 ` [PATCH 1/1] Add the `p4-pre-submit` hook Chen Bin
2018-07-27 18:15 ` Eric Sunshine
2018-07-30 18:07 ` Junio C Hamano
2018-07-30 18:48 ` Luke Diamand
2018-07-30 21:01 ` Junio C Hamano
2018-07-31 8:46 ` SZEDER Gábor
2018-07-31 13:40 ` Luke Diamand
2018-07-31 14:40 ` Junio C Hamano
2018-07-31 19:54 ` Luke Diamand
2018-08-01 14:57 ` chen bin
2018-08-01 15:10 ` Junio C Hamano
2018-08-01 15:54 ` Chen Bin
2018-08-01 17:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQQmOpEpUNSjw58b-_+Ep3v0XA+vuqqqgHVOaFgtKt3fA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=chenbin.sh@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).