From: Junio C Hamano <gitster@pobox.com>
To: chen bin <chenbin.sh@gmail.com>
Cc: "Luke Diamand" <luke@diamand.org>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Git Users" <git@vger.kernel.org>
Subject: Re: [PATCH 1/1] Add the `p4-pre-submit` hook
Date: Wed, 01 Aug 2018 08:10:38 -0700 [thread overview]
Message-ID: <xmqqmuu686mp.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAAE-R+8UA5S3Y4iWw=njtVVn8cu+7s8E7L9fS6UY=Q_a5-JwwQ@mail.gmail.com> (chen bin's message of "Thu, 2 Aug 2018 00:57:19 +1000")
chen bin <chenbin.sh@gmail.com> writes:
> I updated the patch. But for some reason the test keep failing at this line,
> `test_must_fail git p4 submit --dry-run >errs 2>&1 &&`.
>
> If I change this line to `test_must_fail git-p4 submit --dry-run >errs
> 2>&1 &&` the test will pass.
Hmph. I somehow suspect that the test also will pass if you changed
it like this:
test_must_fail false >errs 2>&1 &&
IOW, my suspicion is that the shell fails to find "git-p4" [*1*] and
that is why your `test_must_fail git-p4 whatever` lets your test
pass, which is different from the way you _want_ your test_must_fail
succeed, i.e. "git p4 submit" is run with the "--dry-run" option and
exit with non-zero status.
Of course, if the shell cannot find "git-p4", `errs` would not have
the string "Would apply" in it, so the next test also would pass.
>>>> On 31 July 2018 at 10:46, SZEDER Gábor <szeder.dev@gmail.com> wrote:
>>>>>> + test_must_fail git-p4 submit --dry-run >errs 2>&1 &&>
>>>>>> + ! grep "Would apply" err
[Footnote]
*1* As I do not use (nor install) p4, I cannot test "'git p4' works
but 'git-p4' should not work" myself, but by running t0001 with
a trial patch like the following, you can see that we do not
find the dashed form `git-init` on $PATH and the test indeed
fails.
t/t0001-init.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0001-init.sh b/t/t0001-init.sh
index 0681300707..8c598a0d84 100755
--- a/t/t0001-init.sh
+++ b/t/t0001-init.sh
@@ -31,7 +31,7 @@ check_config () {
}
test_expect_success 'plain' '
- git init plain &&
+ git-init plain &&
check_config plain/.git false unset
'
next prev parent reply other threads:[~2018-08-01 15:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 11:27 [PATCH 1/1] add hook pre-p4-submit Chen Bin
2018-07-25 8:37 ` Luke Diamand
2018-07-25 9:14 ` Ævar Arnfjörð Bjarmason
2018-07-25 11:10 ` chen bin
2018-07-25 13:43 ` Chen Bin
2018-07-25 20:00 ` Eric Sunshine
2018-07-25 20:21 ` Junio C Hamano
2018-07-26 2:08 ` chen bin
2018-07-26 9:21 ` Eric Sunshine
2018-07-26 21:09 ` Luke Diamand
2018-07-27 1:31 ` chen bin
2018-07-26 13:41 ` Chen Bin
2018-07-26 16:49 ` Junio C Hamano
2018-07-26 21:20 ` Eric Sunshine
2018-07-27 11:22 ` [PATCH 1/1] Add the `p4-pre-submit` hook Chen Bin
2018-07-27 18:15 ` Eric Sunshine
2018-07-30 18:07 ` Junio C Hamano
2018-07-30 18:48 ` Luke Diamand
2018-07-30 21:01 ` Junio C Hamano
2018-07-31 8:46 ` SZEDER Gábor
2018-07-31 13:40 ` Luke Diamand
2018-07-31 14:40 ` Junio C Hamano
2018-07-31 19:54 ` Luke Diamand
2018-08-01 14:57 ` chen bin
2018-08-01 15:10 ` Junio C Hamano [this message]
2018-08-01 15:54 ` Chen Bin
2018-08-01 17:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmuu686mp.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=chenbin.sh@gmail.com \
--cc=git@vger.kernel.org \
--cc=luke@diamand.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).