From: Junio C Hamano <firstname.lastname@example.org> To: Glen Choo <email@example.com> Cc: Philippe Blain <firstname.lastname@example.org>, Glen Choo via GitGitGadget <email@example.com>, firstname.lastname@example.org, Huang Zou <email@example.com>, Josh Steadmon <firstname.lastname@example.org> Subject: Re: [PATCH v2] pull: only pass '--recurse-submodules' to subcommands Date: Thu, 12 May 2022 13:37:47 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> (Glen Choo's message of "Wed, 11 May 2022 16:21:55 -0700") Glen Choo <email@example.com> writes: > Hm, yes that makes more sense. The commit message leads with the bug, so > it's more consistent to mention the bug in the title too. > > It's arguably more _correct_ to say that passing only the CLI option is > the desired result, Correct. If it were clear that the title meant "teach 'git pull' to try affecting the recursive behaviour of subcommands only when it got '--recurse-submodules' on its command line", I wouldn't have waited for retitling. It however is easy to misread the original title in such a way that the mention of '--recurse-submodules' refers to the fact that 'pull' invokes 'fetch' and passes the "--recurse-submodules" command line option, and "only" incorrectly hints that 'pull' passes only that option and no other option from the command line when it does so. That will be puzzling because (1) that is clearly not what we do in today's code, suggesting this is a totally different change from what we have in the patch, and (2) it is not clear what we want to achieve by changing the code in such a drastic way to stop passing "--all" and other options to "fetch". So, it is arguable, but the original title does not say what we wanted it to say, exactly.
next prev parent reply other threads:[~2022-05-12 20:38 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-09 23:27 [PATCH] " Glen Choo via GitGitGadget 2022-05-10 0:09 ` Junio C Hamano 2022-05-10 0:44 ` Junio C Hamano 2022-05-10 13:28 ` Philippe Blain 2022-05-10 18:27 ` Glen Choo 2022-05-10 18:43 ` Glen Choo 2022-05-10 19:25 ` [PATCH v2] " Glen Choo via GitGitGadget 2022-05-11 22:30 ` Philippe Blain 2022-05-11 22:34 ` Junio C Hamano 2022-05-11 22:35 ` Philippe Blain 2022-05-11 23:21 ` Glen Choo 2022-05-12 20:37 ` Junio C Hamano [this message] 2022-05-11 23:42 ` [PATCH v3] pull: do not let submodule.recurse override fetch.recurseSubmodules Glen Choo via GitGitGadget 2022-05-12 20:38 ` Junio C Hamano 2022-05-12 23:35 ` Philippe Blain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v2] pull: only pass '\''--recurse-submodules'\'' to subcommands' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).